linux-kernel - RE: [LINUX PATCH v2] spi: spi-mem: Fix build error without CONFIG_SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Apr 2019 11:34:54 +0000
From:   Naga Sureshkumar Relli <nagasure@...inx.com>
To:     Mark Brown <broonie@...nel.org>
CC:     "yuehaibing@...wei.com" <yuehaibing@...wei.com>,
        "vigneshr@...com" <vigneshr@...com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        Michal Simek <michals@...inx.com>,
        "nagasuresh12@...il.com" <nagasuresh12@...il.com>
Subject: RE: [LINUX PATCH v2] spi: spi-mem: Fix build error without
 CONFIG_SPI_MEM

Hi Mark,

> -----Original Message-----
> From: Mark Brown <broonie@...nel.org>
> Sent: Wednesday, April 10, 2019 4:01 PM
> To: Naga Sureshkumar Relli <nagasure@...inx.com>
> Cc: yuehaibing@...wei.com; vigneshr@...com; linux-kernel@...r.kernel.org; linux-
> spi@...r.kernel.org; Michal Simek <michals@...inx.com>; nagasuresh12@...il.com
> Subject: Re: [LINUX PATCH v2] spi: spi-mem: Fix build error without CONFIG_SPI_MEM
> 
> On Wed, Apr 10, 2019 at 11:14:45AM +0530, Naga Sureshkumar Relli wrote:
> > When building with CONFIG_SPI_MEM is not set gc warns this:
> >
> > drivers/spi/spi-zynq-qspi.o: In function `zynq_qspi_supports_op':
> > spi-zynq-qspi.c:(.text+0x1da): undefined reference to `spi_mem_default_supports_op'
> >
> > Fixes: 67dca5e580f1 ("spi: spi-mem: Add support for Zynq QSPI
> > controller")
> >
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> > Signed-off-by: Naga Sureshkumar Relli
> > <naga.sureshkumar.relli@...inx.com>
> 
> Why is there a signed off by for YueHaibing here?  Did they write the patch (in which case the
> authorship is incorrect)?
Yes, YueHaibing has wrote this patch.
I will update the Author name.

> 
> You've also got an extra blank line between the Fixes and the rest of the tags which is unusual
> and might confuse some tools.
Ok I will remove that extra line.

Thanks,
Naga Sureshkumar Relli