linux-kernel - Re: [PATCH] PCI: altera: Fix no return warning for altera_pcie_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 May 2019 15:54:31 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Ley Foon Tan <lftan.linux@...il.com>
Cc:     Ley Foon Tan <ley.foon.tan@...el.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        linux-kernel@...r.kernel.org, linux-pci <linux-pci@...r.kernel.org>
Subject: Re: [PATCH] PCI: altera: Fix no return warning for
 altera_pcie_irq_teardown()

On Fri, May 24, 2019 at 10:17:28AM +0800, Ley Foon Tan wrote:
> On Fri, May 24, 2019 at 10:15 AM Ley Foon Tan <ley.foon.tan@...el.com> wrote:
> >
> > Fix compilation warning caused by patch "PCI: altera: Allow building as module".
> >
> > drivers/pci/controller/pcie-altera.c: In function ‘altera_pcie_irq_teardown’:
> > drivers/pci/controller/pcie-altera.c:723:1: warning: no return statement in function returning non-void [-Wreturn-type]
> >  }
> >
> > Signed-off-by: Ley Foon Tan <ley.foon.tan@...el.com>
> > ---
> >  drivers/pci/controller/pcie-altera.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/pcie-altera.c b/drivers/pci/controller/pcie-altera.c
> > index 6c86bc69ace8..27222071ace7 100644
> > --- a/drivers/pci/controller/pcie-altera.c
> > +++ b/drivers/pci/controller/pcie-altera.c
> > @@ -706,7 +706,7 @@ static int altera_pcie_init_irq_domain(struct altera_pcie *pcie)
> >         return 0;
> >  }
> >
> > -static int altera_pcie_irq_teardown(struct altera_pcie *pcie)
> > +static void altera_pcie_irq_teardown(struct altera_pcie *pcie)
> >  {
> >         irq_set_chained_handler_and_data(pcie->irq, NULL, NULL);
> >         irq_domain_remove(pcie->irq_domain);
> > --
> > 2.19.0
> >
> Hi
> 
> You can squash this patch to this https://lkml.org/lkml/2019/4/24/18
> "PCI: altera: Allow building as module" if want.

Done, thanks.

Lorenzo