linux-kernel - Re: [PATCH 5/6] soc: qcom: add OCMEM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Jun 2019 22:02:00 -0400
From:   Brian Masney <masneyb@...tation.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>, robdclark@...il.com
Cc:     agross@...nel.org, david.brown@...aro.org, sean@...rly.run,
        robh+dt@...nel.org, airlied@...ux.ie, daniel@...ll.ch,
        mark.rutland@....com, jonathan@...ek.ca,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 5/6] soc: qcom: add OCMEM driver

Hi Rob Clark,

On Sun, Jun 16, 2019 at 10:41:06AM -0700, Bjorn Andersson wrote:
> > diff --git a/drivers/soc/qcom/ocmem.xml.h b/drivers/soc/qcom/ocmem.xml.h
> 
> I would prefer that these lived at the top of the c file, rather than
> being generated.

I think it would be nice to make this change as well.

Rob C: Your original file ocmem.xml.h was licensed under the MIT
license. I just wanted confirmation from you that it's OK to put
the contents of that file into ocmem.c which has the GPL 2.0 only
SPDX license tag. This will relicense the work. I imagine it's not
an issue but I just wanted to get confirmation so there is no
ambiguity regarding the licensing in the future.

Brian


> 
> > new file mode 100644
> > index 000000000000..b4bfb85d1e33
> > --- /dev/null
> > +++ b/drivers/soc/qcom/ocmem.xml.h
> > @@ -0,0 +1,86 @@
> > +/* SPDX-License-Identifier: MIT */
> > +
> > +#ifndef OCMEM_XML
> > +#define OCMEM_XML
> > +
> > +/* Autogenerated file, DO NOT EDIT manually!
> > +
> > +This file was generated by the rules-ng-ng headergen tool in this git repository:
> > +http://github.com/freedreno/envytools/
> > +git clone https://github.com/freedreno/envytools.git
> > +
> > +The rules-ng-ng source files this header was generated from are:
> > +- /home/robclark/src/freedreno/envytools/rnndb/adreno/ocmem.xml         (   1773 bytes, from 2015-09-24 17:30:00)
> > +
> > +Copyright (C) 2013-2015 by the following authors:
> > +- Rob Clark <robdclark@...il.com> (robclark)
> > +*/