linux-kernel - Re: [patch 28/29] x86/hpet: Use common init for legacy clockevent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Jun 2019 23:13:29 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
        Ashok Raj <ashok.raj@...el.com>,
        Andi Kleen <andi.kleen@...el.com>,
        Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>,
        Stephane Eranian <eranian@...gle.com>,
        Ravi Shankar <ravi.v.shankar@...el.com>
Subject: Re: [patch 28/29] x86/hpet: Use common init for legacy clockevent


* Thomas Gleixner <tglx@...utronix.de> wrote:

> +static void __init hpet_legacy_clockevent_register(struct hpet_channel *hc)
> +{
> +	/*
> +	 * Start HPET with the boot CPU's cpumask and make it global after
> +	 * the IO_APIC has been initialized.
> +	 */
> +	hc->cpu = boot_cpu_data.cpu_index;
> +	strncpy(hc->name, "hpet", sizeof(hc->name));
> +	hpet_init_clockevent(hc, 50);
> +
> +	hc->evt.tick_resume	= hpet_clkevt_legacy_resume;
> +
> +	/*
> +	 * Legacy horrors and sins from the past. HPET used periodic mode
> +	 * unconditionally for ever on the legacy channel 0. Removing the

s/for ever
 /forever

With that typo fixed:

Reviewed-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo