linux-kernel - Re: [PATCH v2 3/5] mips/PCI: Remove HAVE_ARCH_PCI_RESOURCE_TO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Jul 2019 18:54:33 +0000
From:   Paul Burton <paul.burton@...s.com>
To:     Denis Efremov <efremov@...ux.com>
CC:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <jhogan@...nel.org>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/5] mips/PCI: Remove HAVE_ARCH_PCI_RESOURCE_TO_USER

Hi Denis,

On Mon, Jul 29, 2019 at 01:13:59PM +0300, Denis Efremov wrote:
> The function pci_resource_to_user() was turned to a weak one. Thus,
> mips-specific version will automatically override the generic one
> and the HAVE_ARCH_PCI_RESOURCE_TO_USER macro should be removed.
> 
> Signed-off-by: Denis Efremov <efremov@...ux.com>

Assuming this is the way Bjorn wants to go:

    Acked-by: Paul Burton <paul.burton@...s.com>

Thanks,
    Paul

> ---
>  arch/mips/include/asm/pci.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/include/asm/pci.h b/arch/mips/include/asm/pci.h
> index 436099883022..6f48649201c5 100644
> --- a/arch/mips/include/asm/pci.h
> +++ b/arch/mips/include/asm/pci.h
> @@ -108,7 +108,6 @@ extern unsigned long PCIBIOS_MIN_MEM;
>  
>  #define HAVE_PCI_MMAP
>  #define ARCH_GENERIC_PCI_MMAP_RESOURCE
> -#define HAVE_ARCH_PCI_RESOURCE_TO_USER
>  
>  /*
>   * Dynamic DMA mapping stuff.
> -- 
> 2.21.0
>