linux-kernel - Re: [PATCH v2 2/4] i2c/busses/i2c-icy: Add LTC2990 present on 2019 board revision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Aug 2019 21:52:55 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Max Staudt <max@...as.org>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Linux I2C <linux-i2c@...r.kernel.org>,
        linux-hwmon@...r.kernel.org,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Linux/m68k <linux-m68k@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
Subject: Re: [PATCH v2 2/4] i2c/busses/i2c-icy: Add LTC2990 present on 2019
 board revision

> However, I'm not sure I'm supposed to do that. I went by Documentation/i2c/instantiating-devices, which in "Method 2" says:
> 
>   The driver which instantiated the I2C device is responsible for destroying
>   it on cleanup. This is done by calling i2c_unregister_device() on the
>   pointer that was earlier returned by i2c_new_device() or
>   i2c_new_probed_device().
> 
> 
> So, what is preferred and why?

What the documentation says is preferred. For consistency and because of
the general "free what you allocated" rule. If we have arguments to
change that for i2c_unregister_device(), we would need to do this
tree-wide anyhow. Until then, the above is valid.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)