linux-kernel - Re: [PATCH] drm: Remove redundant of_device_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 20 Sep 2019 16:09:21 -0400
From:   Sean Paul <sean@...rly.run>
To:     megous@...ous.com
Cc:     dri-devel <dri-devel@...ts.freedesktop.org>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm: Remove redundant of_device_is_available check

On Fri, Sep 20, 2019 at 1:29 PM <megous@...ous.com> wrote:
>
> From: Ondrej Jirman <megous@...ous.com>
>
> This check is already performed by of_graph_get_remote_node. No
> need to repeat it immediately after the call.
>
> Signed-off-by: Ondrej Jirman <megous@...ous.com>

Thanks for your patch, I've applied it to drm-misc-next.

Sean

> ---
>  drivers/gpu/drm/drm_of.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> index 43d89dd59c6b..0ca58803ba46 100644
> --- a/drivers/gpu/drm/drm_of.c
> +++ b/drivers/gpu/drm/drm_of.c
> @@ -247,17 +247,12 @@ int drm_of_find_panel_or_bridge(const struct device_node *np,
>                 *panel = NULL;
>
>         remote = of_graph_get_remote_node(np, port, endpoint);
>         if (!remote)
>                 return -ENODEV;
>
> -       if (!of_device_is_available(remote)) {
> -               of_node_put(remote);
> -               return -ENODEV;
> -       }
> -
>         if (panel) {
>                 *panel = of_drm_find_panel(remote);
>                 if (!IS_ERR(*panel))
>                         ret = 0;
>                 else
>                         *panel = NULL;
> --
> 2.23.0
>