linux-kernel - [PATCH] vhost/vsock: Micro optimize error handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 23 Sep 2019 15:41:00 +0800
From:   "richard.peng@...o.com" <richard.peng@...o.com>
To:     mst <mst@...hat.com>, davem <davem@...emloft.net>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>
Subject: [PATCH] vhost/vsock: Micro optimize error handle

When a vq error, there is no need to operate on the unmodified vq.

Signed-off-by:Peng Hao <richard.peng@...o.com>
---
 drivers/vhost/vsock.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
index 6a50e1d..0bed19d 100644
--- a/drivers/vhost/vsock.c
+++ b/drivers/vhost/vsock.c
@@ -437,7 +437,7 @@ static void vhost_vsock_handle_rx_kick(struct vhost_work *work)
 static int vhost_vsock_start(struct vhost_vsock *vsock)
 {
 	struct vhost_virtqueue *vq;
-	size_t i;
+	size_t i, j;
 	int ret;
 
 	mutex_lock(&vsock->dev.mutex);
@@ -473,8 +473,8 @@ static int vhost_vsock_start(struct vhost_vsock *vsock)
 	vq->private_data = NULL;
 	mutex_unlock(&vq->mutex);
 
-	for (i = 0; i < ARRAY_SIZE(vsock->vqs); i++) {
-		vq = &vsock->vqs[i];
+	for (j = 0; j < i; j++) {
+		vq = &vsock->vqs[j];
 
 		mutex_lock(&vq->mutex);
 		vq->private_data = NULL;
-- 
2.7.4