linux-kernel - Re: [PATCH v2 3/9] csky: entry: Remove unneeded need

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Sep 2019 00:55:47 +0800
From:   Guo Ren <guoren@...nel.org>
To:     Valentin Schneider <valentin.schneider@....com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/9] csky: entry: Remove unneeded need_resched() loop

Ok, I'll put in my tree :)

On Mon, Sep 23, 2019 at 10:36 PM Valentin Schneider
<valentin.schneider@....com> wrote:
>
> Since the enabling and disabling of IRQs within preempt_schedule_irq()
> is contained in a need_resched() loop, we don't need the outer arch
> code loop.
>
> Acked-by: Guo Ren <guoren@...nel.org>
> Signed-off-by: Valentin Schneider <valentin.schneider@....com>
> ---
>  arch/csky/kernel/entry.S | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/arch/csky/kernel/entry.S b/arch/csky/kernel/entry.S
> index a7e84ccccbd8..679afbcc2001 100644
> --- a/arch/csky/kernel/entry.S
> +++ b/arch/csky/kernel/entry.S
> @@ -292,11 +292,7 @@ ENTRY(csky_irq)
>         ldw     r8, (r9, TINFO_FLAGS)
>         btsti   r8, TIF_NEED_RESCHED
>         bf      2f
> -1:
>         jbsr    preempt_schedule_irq    /* irq en/disable is done inside */
> -       ldw     r7, (r9, TINFO_FLAGS)   /* get new tasks TI_FLAGS */
> -       btsti   r7, TIF_NEED_RESCHED
> -       bt      1b                      /* go again */
>  #endif
>  2:
>         jmpi    ret_from_exception
> --
> 2.22.0
>


-- 
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/