[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 10 Oct 2019 18:20:06 +0200
From: Jiri Olsa <jolsa@...hat.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
Ingo Molnar <mingo@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Michael Petlan <mpetlan@...hat.com>
Subject: Re: [PATCH 27/36] libperf: Add perf_evlist__for_each_mmap function
On Thu, Oct 10, 2019 at 01:06:22PM -0300, Arnaldo Carvalho de Melo wrote:
SNIP
> > diff --git a/tools/perf/lib/include/internal/evlist.h b/tools/perf/lib/include/internal/evlist.h
> > index be0b25a70730..513a85cb7bfe 100644
> > --- a/tools/perf/lib/include/internal/evlist.h
> > +++ b/tools/perf/lib/include/internal/evlist.h
> > @@ -25,6 +25,8 @@ struct perf_evlist {
> > struct hlist_head heads[PERF_EVLIST__HLIST_SIZE];
> > struct perf_mmap *mmap;
> > struct perf_mmap *mmap_ovw;
> > + struct perf_mmap *mmap0;
> > + struct perf_mmap *mmap_ovw0;
>
> Why do you use this funny name? Using this "0" suffix? Please pick
> something more informative and add a comment on the struct perf_evlist
> definiton.
it's the first mmap.. I can spell it ;-)
>
> I've processed up to the previous patch, pushed to acme/tmp.perf/core.
great, I'll rebase and continue from there
thanks,
jirka
Powered by blists - more mailing lists