linux-kernel - Re: [PATCH] arm64: dts: rockchip: Enable PCIe for Radxa Rock Pi 4 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 15 Nov 2019 21:16:29 +0300
From:   "Matwey V. Kornilov" <matwey@....msu.ru>
To:     Heiko Stübner <heiko@...ech.de>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Ezequiel Garcia <ezequiel@...labora.com>,
        Akash Gajjar <akash@...nedev.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/Rockchip SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        "open list:ARM/Rockchip SoC support" 
        <linux-rockchip@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Enable PCIe for Radxa Rock Pi 4 board

пт, 15 нояб. 2019 г. в 21:14, Heiko Stübner <heiko@...ech.de>:
>
> Hi Matwey,
>
> Am Freitag, 15. November 2019, 19:08:21 CET schrieb Matwey V. Kornilov:
> > Radxa Rock Pi 4 is equipped with M.2 PCIe slot,
> > so enable PCIe for the board.
> >
> > The changes has been tested with Intel SSD 660p series device.
> >
> >     01:00.0 Class 0108: Device 8086:f1a8 (rev 03)
> >
> > Signed-off-by: Matwey V. Kornilov <matwey@....msu.ru>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
> > index 1ae1ebd4efdd..9c2927faba41 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
> > @@ -463,6 +463,20 @@
> >       pmu1830-supply = <&vcc_3v0>;
> >  };
> >
> > +&pcie_phy {
> > +     status = "okay";
> > +};
> > +
> > +&pcie0 {
> > +     status = "okay";
> > +
> > +     ep-gpios = <&gpio4 RK_PD3 GPIO_ACTIVE_HIGH>;
> > +     num-lanes = <4>;
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pcie_clkreqnb_cpm>;
> > +     max-link-speed = <2>;
>
> the RockPi schematics should be available, so could you also check
> the supply regulators and add them please?
>
> Thanks
> Heiko

Hi,

What do you mean? pcie 3.3v regulator is already in dts. I've checked
that its gpio is correctly configured.

>
>
> > +};
> > +
> >  &pinctrl {
> >       bt {
> >               bt_enable_h: bt-enable-h {
> >
>
>
>
>


-- 
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia
119234, Moscow, Universitetsky pr-k 13, +7 (495) 9392382