linux-kernel - Re: [EXT] Re: [PATCH 0/5] Add V4L2 driver for i.MX8 JPEG Encoder/Decoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Nov 2019 12:34:13 +0000
From:   Mirela Rabulea <mirela.rabulea@....com>
To:     "mchehab@...nel.org" <mchehab@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>
CC:     dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "laurent.pinchart+renesas@...asonboard.com" 
        <laurent.pinchart+renesas@...asonboard.com>,
        Aisheng Dong <aisheng.dong@....com>,
        "nicolas@...fresne.ca" <nicolas@...fresne.ca>,
        Laurentiu Palcu <laurentiu.palcu@....com>,
        "paul.kocialkowski@...tlin.com" <paul.kocialkowski@...tlin.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        Robert Chiras <robert.chiras@....com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "niklas.soderlund+renesas@...natech.se" 
        <niklas.soderlund+renesas@...natech.se>,
        Daniel Baluta <daniel.baluta@....com>,
        Leonard Crestez <leonard.crestez@....com>,
        "dafna.hirschfeld@...labora.com" <dafna.hirschfeld@...labora.com>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
Subject: Re: [EXT] Re: [PATCH 0/5] Add V4L2 driver for i.MX8 JPEG
 Encoder/Decoder

Hi Hans,

On Vi, 2019-11-08 at 15:06 +0100, Hans Verkuil wrote:
> > Is there a "good example" of a v4l m2m driver that passes these
> vim2m. Also drivers/media/platform/mtk-jpeg/ (although I'm not sure
> when
> it was last tested with v4l2-compliance, so it might be a bit out of
> date).
> 
> > 
> > streaming tests? That would save some time on my side.

Thanks a lot for the examples.
I'm sending _v2 of the patch, with fixes for streaming tests.
One mention here, I dropped the support for USERPTR buffers, based on
this:
https://lwn.net/Articles/447435/
"VB2_USERPTR: buffers allocated in user space. Normally, only devices
which can do scatter/gather I/O can deal with user-space buffers.
Interestingly, videobuf2 supports contiguous buffers allocated by user
space; the only way to get those, though, is to use some sort of
special mechanism like the out-of-tree Android "pmem" driver.
Contiguous I/O to huge pages is not supported."

I wonder if VB2_USERPTR make sense together
with &vb2_dma_contig_memops? I see at least 1 driver with this
combination (s5p-jpeg), I would be surprised if that passes the
streaming tests.

Regards,
Mirela