linux-kernel - Re: [PATCH 3/3] clone.2: Use pid_t for clone3() {child,parent}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 17 Nov 2019 19:02:04 +0100
From:   "Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
To:     Christian Brauner <christian@...uner.io>
Cc:     mtk.manpages@...il.com, adrian@...as.de, akpm@...ux-foundation.org,
        arnd@...db.de, avagin@...il.com, christian.brauner@...ntu.com,
        dhowells@...hat.com, fweimer@...hat.com, jannh@...gle.com,
        keescook@...omium.org, linux-api@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-man@...r.kernel.org,
        mingo@...e.hu, oleg@...hat.com, xemul@...tuozzo.com
Subject: Re: [PATCH 3/3] clone.2: Use pid_t for clone3() {child,parent}_tid

On 11/16/19 12:41 PM, Christian Brauner wrote:
> From: Christian Brauner <christian.brauner@...ntu.com>
>
> Advertise to userspace that they should use proper pid_t types for
> arguments returning a pid.
> The kernel-internal struct kernel_clone_args currently uses int as type
> and since POSIX mandates that pid_t is a signed integer type and glibc
> and friends use int this is not an issue. After the merge window for
> v5.5 closes we can switch struct kernel_clone_args over to using pid_t
> as well without any danger in regressing current userspace.
> Also note, that the new set tid feature which will be merged for v5.5
> uses pid_t types as well.

Thanks taking a further pass throuh this page, Christian, 

Patch applied.

Cheers,

Michael

 
> Signed-off-by: Christian Brauner <christian.brauner@...ntu.com>
> ---
>  man2/clone.2 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/man2/clone.2 b/man2/clone.2
> index faff2ada6..bf2d7c731 100644
> --- a/man2/clone.2
> +++ b/man2/clone.2
> @@ -183,9 +183,9 @@ is a structure of the following form:
>  struct clone_args {
>      u64 flags;        /* Flags bit mask */
>      u64 pidfd;        /* Where to store PID file descriptor
> -                         (\fIint *\fP) */
> +                         (\fIpid_t *\fP) */
>      u64 child_tid;    /* Where to store child TID,
> -                         in child's memory (\fIint *\fP) */
> +                         in child's memory (\fIpid_t *\fP) */
>      u64 parent_tid;   /* Where to store child TID,
>                           in parent's memory (\fIint *\fP) */
>      u64 exit_signal;  /* Signal to deliver to parent on
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/