linux-kernel - Re: [PATCH] ASoC: simple-card: Don't create separate link when platform is present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   10 Dec 2019 09:09:15 +0900
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Daniel Baluta <daniel.baluta@....com>
Cc:     broonie@...nel.org, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: simple-card: Don't create separate link when platform is present


Hi

> In normal sound case all DAIs are detected as CPU-Codec.
> simple_dai_link_of supports the presence of a platform but it counts
> it as a CPU DAI resulting in the creation of an extra link.
> 
> Adding a platform property to a link description like:
> 
> simple-audio-card,dai-link {
> 	cpu {
> 		sound-dai = <&sai1>;
> 	};
> 	plat {
> 		sound-dai = <&dsp>;
> 	};
> 	codec {
> 		sound-dai = <&wm8960>;
> 	}
> 
> will result in the creation of two links:
> 	* sai1 <-> wm8960
> 	* dsp  <-> wm8960
> 
> which is obviously not what we want. We just want one single link
> with:
> 	* sai1 <-> wm8960 (and platform set to dsp).
> 
> Signed-off-by: Daniel Baluta <daniel.baluta@....com>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

Thank you for your help !!
Best regards
---
Kuninori Morimoto