linux-kernel - Re: linux-next: build failure after merge of the selinux tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 Dec 2019 21:25:40 -0500
From:   Paul Moore <paul@...l-moore.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Stephen Smalley <sds@...ho.nsa.gov>,
        James Morris <jamorris@...ux.microsoft.com>
Subject: Re: linux-next: build failure after merge of the selinux tree

On Mon, Dec 9, 2019 at 8:40 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> Hi all,
>
> After merging the selinux tree, today's linux-next build (powerpc
> pseries_le_defconfig) failed like this:
>
> ld: security/lsm_audit.o:(.toc+0x0): undefined reference to `lockdown_reasons'
>
> Caused by commit
>
>   59438b46471a ("security,lockdown,selinux: implement SELinux lockdown")
>
> CONFIG_SECURITY is not set for this build, but CONFIG_AUDIT is set.
>
> I applied the following hack for today:
>
> From: Stephen Rothwell <sfr@...b.auug.org.au>
> Date: Tue, 10 Dec 2019 12:28:16 +1100
> Subject: [PATCH] security,lockdown,selinux: hack for !CONFIG_SECURITY
>
> Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
> ---
>  security/lsm_audit.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/security/lsm_audit.c b/security/lsm_audit.c
> index 2d2bf49016f4..f97a3337f307 100644
> --- a/security/lsm_audit.c
> +++ b/security/lsm_audit.c
> @@ -427,8 +427,10 @@ static void dump_common_audit_data(struct audit_buffer *ab,
>                                  a->u.ibendport->port);
>                 break;
>         case LSM_AUDIT_DATA_LOCKDOWN:
> +#ifdef CONFIG_SECURITY
>                 audit_log_format(ab, " lockdown_reason=");
>                 audit_log_string(ab, lockdown_reasons[a->u.reason]);
> +#endif
>                 break;
>         } /* switch (a->type) */
>  }

Thanks for letting me know.  I'm sorry about that Stephen, I'll send
out a little more generic patch in just a minute as a RFC.

-- 
paul moore
www.paul-moore.com