linux-kernel - Re: [PATCH] mailbox: make cmd_dma a _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Dec 2019 13:58:20 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     "Ben Dooks (Codethink)" <ben.dooks@...ethink.co.uk>,
        linux-kernel@...ts.codethink.co.uk
Cc:     bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mailbox: make cmd_dma a __le64 to reduce warnings

On 12/19/19 9:01 AM, Ben Dooks (Codethink) wrote:
> The cmd_dma of the brcm_sba_command is often set from the
> result of cpu_to_le64, which means it should really be an
> __le64 type to avoid warnings such as:

It actually is always set from the result of cpu_to_le64() which is why
this is the correct thing to do.

> 
> drivers/dma/bcm-sba-raid.c:583:25: warning: incorrect type in assignment (different base types)
> drivers/dma/bcm-sba-raid.c:583:25:    expected unsigned long long [usertype]
> drivers/dma/bcm-sba-raid.c:583:25:    got restricted __le64 [usertype]
> 
> Note, this header dos not seem to be covered by the maintainers
> file, so just sending to the normal lists.
> 
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@...ethink.co.uk>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian