linux-kernel - Re: [PATCH 3/3] Staging: sm750fb: sm750.h:Fixed Coding Style Issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Dec 2019 10:35:04 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Simran Sandhu <f20171454@...erabad.bits-pilani.ac.in>
Cc:     sudipm.mukherjee@...il.comm, teddy.wang@...iconmotion.com,
        linux-fbdev@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] Staging: sm750fb: sm750.h:Fixed Coding Style Issue

On Thu, Dec 19, 2019 at 02:35:53PM +0530, Simran Sandhu wrote:
> Fixed the checkpath error: function definition arguments
> should also have identifier names
> 
> Signed-of-by: Simran Sandhu <f20171454@...erabad.bits-pilani.ac.in>
> ---
>  drivers/staging/sm750fb/sm750.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
> index ce90adcb449d..cf986bad7210 100644
> --- a/drivers/staging/sm750fb/sm750.h
> +++ b/drivers/staging/sm750fb/sm750.h
> @@ -66,9 +66,9 @@ struct lynx_accel {
>  						u32, u32, u32, u32,
>  						u32, u32, u32, u32);
>  
> -	int (*de_imageblit)(struct lynx_accel *, const char *, u32, u32, u32, u32,
> -							       u32, u32, u32, u32,
> -							       u32, u32, u32, u32);
> +	int (*de_imageblit)(struct lynx_accel *A, const char *B, u32 C, u32 D,
> +		       						u32 E, u32 F, u32 G, u32 H, u32 I,
> +							       	u32 J, u32 K, u32 L, u32 M, u32 N);
>  

You just caused another coding style violation with this one :(

Always run your patches though checkpatch.pl to ensure you do not add
new problems when trying to fix up things.

greg k-h