linux-kernel - Re: [PATCH 2/2] sched: Extract the task putting code from pick_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Apr 2020 22:23:19 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Valentin Schneider <valentin.schneider@....com>,
        Chen Yu <yu.c.chen@...el.com>, linux-kernel@...r.kernel.org,
        Ingo Molnar <mingo@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>
Subject: Re: [PATCH 2/2] sched: Extract the task putting code from
 pick_next_task()

On Tue, 21 Apr 2020 01:13:55 +0200
Peter Zijlstra <peterz@...radead.org> wrote:

> > The 'finish' thing isn't too far from the truth; it's the last thing we
> > need to do with the prev task (in terms of sched bookkeeping, I mean) -
> > and in Chen's defence ISTR Peter suggested that name.
> > 
> > Seeing as it's a "supercharged" put_prev_task(), I could live with the
> > marginally shorter "put_prev_task_balance()".  
> 
> What Valentin said; it's the last put we do before picking a new task.
> Also, I don't like long names. That said, I'm open to short and
> appropriate suggestions.

I wont bikeshed this too much.

Is the "finish" more appropriate with the other use cases that are
coming. I do like that "put_prev_task_balance()" too.

-- Steve