linux-kernel - Re: [PATCH v2 3/3] usb typec: mt6360: Prevent the race condition during module remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Aug 2020 20:34:24 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     cy_huang <u0084500@...il.com>, gregkh@...uxfoundation.org,
        robh+dt@...nel.org, matthias.bgg@...il.com,
        heikki.krogerus@...ux.intel.com
Cc:     cy_huang@...htek.com, gene_chen@...htek.com,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] usb typec: mt6360: Prevent the race condition
 during module remove

On 8/26/20 8:25 PM, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@...htek.com>
> 
> Prevent the race condition from interrupt and tcpci port unregister
> during module remove.
> 
> Signed-off-by: ChiYuan Huang <cy_huang@...htek.com>

Please squash with the first patch of the series.

Thanks,
Guenter

> ---
>  drivers/usb/typec/tcpm/tcpci_mt6360.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpci_mt6360.c b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> index 6a28193..a381b5d 100644
> --- a/drivers/usb/typec/tcpm/tcpci_mt6360.c
> +++ b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> @@ -164,6 +164,7 @@ static int mt6360_tcpc_remove(struct platform_device *pdev)
>  {
>  	struct mt6360_tcpc_info *mti = platform_get_drvdata(pdev);
>  
> +	disable_irq(mti->irq);
>  	tcpci_unregister_port(mti->tcpci);
>  	return 0;
>  }
>