linux-kernel - Re: [PATCH] mm/damon: Add option to monitor only writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 4 Feb 2022 09:29:58 +0800
From:   kernel test robot <lkp@...el.com>
To:     Pedro Demarchi Gomes <pedrodemargomes@...il.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Pedro Demarchi Gomes <pedrodemargomes@...il.com>,
        SeongJae Park <sj@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/damon: Add option to monitor only writes

Hi Pedro,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on hnaz-mm/master]

url:    https://github.com/0day-ci/linux/commits/Pedro-Demarchi-Gomes/mm-damon-Add-option-to-monitor-only-writes/20220203-211407
base:   https://github.com/hnaz/linux-mm master
config: hexagon-randconfig-r041-20220130 (https://download.01.org/0day-ci/archive/20220204/202202040414.4fF2j3mp-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project a73e4ce6a59b01f0e37037761c1e6889d539d233)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/0958bb7e2514b62f174b8e5ccfdcff07ce2a2b6b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Pedro-Demarchi-Gomes/mm-damon-Add-option-to-monitor-only-writes/20220203-211407
        git checkout 0958bb7e2514b62f174b8e5ccfdcff07ce2a2b6b
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> mm/damon/prmtv-common.c:87:7: error: implicit declaration of function 'pmd_dirty' [-Werror,-Wimplicit-function-declaration]
                   if (pmd_dirty(old))
                       ^
   mm/damon/prmtv-common.c:87:7: note: did you mean 'pte_dirty'?
   arch/hexagon/include/asm/pgtable.h:301:19: note: 'pte_dirty' declared here
   static inline int pte_dirty(pte_t pte)
                     ^
>> mm/damon/prmtv-common.c:88:10: error: implicit declaration of function 'pmd_mkdirty' [-Werror,-Wimplicit-function-declaration]
                           pmd = pmd_mkdirty(pmd);
                                 ^
>> mm/damon/prmtv-common.c:88:8: error: assigning to 'pmd_t' from incompatible type 'int'
                           pmd = pmd_mkdirty(pmd);
                               ^ ~~~~~~~~~~~~~~~~
>> mm/damon/prmtv-common.c:89:7: error: implicit declaration of function 'pmd_young' [-Werror,-Wimplicit-function-declaration]
                   if (pmd_young(old))
                       ^
   mm/damon/prmtv-common.c:89:7: note: did you mean 'pte_young'?
   arch/hexagon/include/asm/pgtable.h:295:19: note: 'pte_young' declared here
   static inline int pte_young(pte_t pte)
                     ^
>> mm/damon/prmtv-common.c:90:10: error: implicit declaration of function 'pmd_mkyoung' [-Werror,-Wimplicit-function-declaration]
                           pmd = pmd_mkyoung(pmd);
                                 ^
   mm/damon/prmtv-common.c:90:8: error: assigning to 'pmd_t' from incompatible type 'int'
                           pmd = pmd_mkyoung(pmd);
                               ^ ~~~~~~~~~~~~~~~~
>> mm/damon/prmtv-common.c:92:9: error: implicit declaration of function 'pmd_wrprotect' [-Werror,-Wimplicit-function-declaration]
                   pmd = pmd_wrprotect(pmd);
                         ^
   mm/damon/prmtv-common.c:92:9: note: did you mean 'pte_wrprotect'?
   arch/hexagon/include/asm/pgtable.h:315:21: note: 'pte_wrprotect' declared here
   static inline pte_t pte_wrprotect(pte_t pte)
                       ^
   mm/damon/prmtv-common.c:92:7: error: assigning to 'pmd_t' from incompatible type 'int'
                   pmd = pmd_wrprotect(pmd);
                       ^ ~~~~~~~~~~~~~~~~~~
>> mm/damon/prmtv-common.c:95:3: error: implicit declaration of function 'set_pmd_at' [-Werror,-Wimplicit-function-declaration]
                   set_pmd_at(vma->vm_mm, addr, pmdp, pmd);
                   ^
   mm/damon/prmtv-common.c:98:3: error: implicit declaration of function 'set_pmd_at' [-Werror,-Wimplicit-function-declaration]
                   set_pmd_at(vma->vm_mm, addr, pmdp, pmd);
                   ^
   10 errors generated.


vim +/pmd_dirty +87 mm/damon/prmtv-common.c

    78	
    79	static inline void clear_soft_dirty_pmd(struct vm_area_struct *vma,
    80			unsigned long addr, pmd_t *pmdp)
    81	{
    82		pmd_t old, pmd = *pmdp;
    83	
    84		if (pmd_present(pmd)) {
    85			/* See comment in change_huge_pmd() */
    86			old = pmdp_invalidate(vma, addr, pmdp);
  > 87			if (pmd_dirty(old))
  > 88				pmd = pmd_mkdirty(pmd);
  > 89			if (pmd_young(old))
  > 90				pmd = pmd_mkyoung(pmd);
    91	
  > 92			pmd = pmd_wrprotect(pmd);
    93			pmd = pmd_clear_soft_dirty(pmd);
    94	
  > 95			set_pmd_at(vma->vm_mm, addr, pmdp, pmd);
    96		} else if (is_migration_entry(pmd_to_swp_entry(pmd))) {
    97			pmd = pmd_swp_clear_soft_dirty(pmd);
    98			set_pmd_at(vma->vm_mm, addr, pmdp, pmd);
    99		}
   100	}
   101	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org