linux-kernel - Re: [PATCH 5/5] pinctrl: mediatek: common-v1: Commonize spec_ies_smt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Feb 2022 10:54:42 +0800
From:   Chen-Yu Tsai <wenst@...omium.org>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Cc:     sean.wang@...nel.org, linus.walleij@...aro.org,
        matthias.bgg@...il.com, linux-mediatek@...ts.infradead.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, kernel@...labora.com
Subject: Re: [PATCH 5/5] pinctrl: mediatek: common-v1: Commonize
 spec_ies_smt_set callback

On Mon, Feb 21, 2022 at 9:40 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com> wrote:
>
> Il 21/02/22 10:58, Chen-Yu Tsai ha scritto:
> > On Thu, Feb 10, 2022 at 10:21 PM AngeloGioacchino Del Regno
> > <angelogioacchino.delregno@...labora.com> wrote:
> >>
> >> All of the MediaTek pinctrl drivers registering with pinctrl-mtk-common
> >> that are offering a .spec_ies_smt_set() callback are declaring their
> >> own function which is doing exactly the same on all drivers: calling
> >> mtk_pconf_spec_set_ies_smt_range() with their struct and a simple check.
> >>
> >> Commonize this callback by adding the ies and smt structure pointers
> >> to struct mtk_pinctrl_devdata and changing the callback signature to
> >> take it.
> >>
> >> Removing the callback and checking for the existence of the spec_smt
> >> and/or spec_ies data would allow us to staticize the function
> >> mtk_pconf_spec_set_ies_smt_range(), but this solution was avoided as
> >> to keep flexibility, as some SoCs may need to perform a very different
> >> operation compared to what this commonized function is doing.
> >>
> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> >
> > Signed-off-by: Chen-Yu Tsai <wenst@...omium.org>
>
> Hi Chen-Yu,
>
> did you mean Reviewed-by? :-)

(facepalm) Yes.

Reviewed-by: Chen-Yu Tsai <wenst@...omium.org>