linux-kernel - [ammarfaizi2-block:stable/linux-stable-rc/queue/5.4 7/8] fs/ext4/mballoc.c:4547:2: warning: ordered comparison between pointer and integer ('struct super_block *' and 'ushort' (aka 'unsigned short'))

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 2 Oct 2022 09:50:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ritesh Harjani <riteshh@...ux.ibm.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Ammar Faizi <ammarfaizi2@...weeb.org>,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org, Sasha Levin <sashal@...nel.org>,
        Theodore Ts'o <tytso@....edu>
Subject: [ammarfaizi2-block:stable/linux-stable-rc/queue/5.4 7/8]
 fs/ext4/mballoc.c:4547:2: warning: ordered comparison between pointer and
 integer ('struct super_block *' and 'ushort' (aka 'unsigned short'))

tree:   https://github.com/ammarfaizi2/linux-block stable/linux-stable-rc/queue/5.4
head:   c1d9eb13e1f03d70fd064927fd881fe68d0c5472
commit: f0be5d9bae30b6714e9db7a86c486a97304e42d2 [7/8] ext4: mballoc: introduce pcpu seqcnt for freeing PA to improve ENOSPC handling
config: x86_64-randconfig-a014
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ammarfaizi2/linux-block/commit/f0be5d9bae30b6714e9db7a86c486a97304e42d2
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block stable/linux-stable-rc/queue/5.4
        git checkout f0be5d9bae30b6714e9db7a86c486a97304e42d2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/ext4/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> fs/ext4/mballoc.c:4547:2: warning: ordered comparison between pointer and integer ('struct super_block *' and 'ushort' (aka 'unsigned short'))
           mb_debug(sb, "freed %d, retry ? %s\n", freed, ret ? "yes" : "no");
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   fs/ext4/mballoc.h:33:10: note: expanded from macro 'mb_debug'
           if ((n) <= ext4_mballoc_debug) {                                \
               ~~~ ^  ~~~~~~~~~~~~~~~~~~
   1 warning generated.


vim +4547 fs/ext4/mballoc.c

  4527	
  4528	static bool ext4_mb_discard_preallocations_should_retry(struct super_block *sb,
  4529				struct ext4_allocation_context *ac, u64 *seq)
  4530	{
  4531		int freed;
  4532		u64 seq_retry = 0;
  4533		bool ret = false;
  4534	
  4535		freed = ext4_mb_discard_preallocations(sb, ac->ac_o_ex.fe_len);
  4536		if (freed) {
  4537			ret = true;
  4538			goto out_dbg;
  4539		}
  4540		seq_retry = ext4_get_discard_pa_seq_sum();
  4541		if (seq_retry != *seq) {
  4542			*seq = seq_retry;
  4543			ret = true;
  4544		}
  4545	
  4546	out_dbg:
> 4547		mb_debug(sb, "freed %d, retry ? %s\n", freed, ret ? "yes" : "no");
  4548		return ret;
  4549	}
  4550	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (140345 bytes)