linux-kernel - Re: [PATCH v1 1/3] clk: loongson2: add clock dt-bindings include file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Oct 2022 09:46:55 -0400
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Yinbo Zhu <zhuyinbo@...ngson.cn>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Huacai Chen <chenhuacai@...nel.org>,
        WANG Xuerui <kernel@...0n.name>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Jianmin Lv <lvjianmin@...ngson.cn>,
        Yang Li <yang.lee@...ux.alibaba.com>,
        linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev
Subject: Re: [PATCH v1 1/3] clk: loongson2: add clock dt-bindings include file

On 18/10/2022 09:05, Yinbo Zhu wrote:
> This file defines all loongson2 soc clock indexes, it should be
> included in the device tree in which there's device using the
> clocks.
> 
> Signed-off-by: Yinbo Zhu <zhuyinbo@...ngson.cn>
> ---
>  MAINTAINERS                                 |  6 +++++
>  include/dt-bindings/clock/loongson2-clock.h | 29 +++++++++++++++++++++

Use subject prefixes matching the subsystem (git log --oneline -- ...).

These are bindings.

>  2 files changed, 35 insertions(+)
>  create mode 100644 include/dt-bindings/clock/loongson2-clock.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a162b6fba6fe..3db469f51d74 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11914,6 +11914,12 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
>  F:	drivers/clocksource/loongson2_hpet.c
>  
> +LOONGSON2 SOC SERIES CLOCK DRIVER
> +M:	Yinbo Zhu <zhuyinbo@...ngson.cn>
> +L:	linux-clk@...r.kernel.org
> +S:	Maintained
> +F:	include/dt-bindings/clock/loongson2-clock.h
> +
>  LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)
>  M:	Sathya Prakash <sathya.prakash@...adcom.com>
>  M:	Sreekanth Reddy <sreekanth.reddy@...adcom.com>
> diff --git a/include/dt-bindings/clock/loongson2-clock.h b/include/dt-bindings/clock/loongson2-clock.h
> new file mode 100644
> index 000000000000..23806408fe49
> --- /dev/null
> +++ b/include/dt-bindings/clock/loongson2-clock.h

Filename matching the compatible, so:
loongson,ls2k-clk.h

> @@ -0,0 +1,29 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */

Dual license, like bindings, unless you are not allowed.

> +/*
> + * Author: Yinbo Zhu <zhuyinbo@...ngson.cn>
> + * Copyright (C) 2022-2023 Loongson Technology Corporation Limited
> + */
> +
> +#ifndef __DT_BINDINGS_CLOCK_LOONGSON2_H
> +#define __DT_BINDINGS_CLOCK_LOONGSON2_H
> +
> +#define	LOONGSON2_REFCLK_100M				0

Drop weird indentation after define.


Best regards,
Krzysztof