linux-kernel - Re: [PATCH] clk: ti: dra7-atl: don't allocate `parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Oct 2022 10:07:26 +0800
From:   kernel test robot <lkp@...el.com>
To:     Dario Binacchi <dario.binacchi@...rulasolutions.com>,
        linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, michael@...rulasolutions.com,
        Amarula patchwork <linux-amarula@...rulasolutions.com>,
        Dario Binacchi <dario.binacchi@...rulasolutions.com>,
        Allison Randal <allison@...utok.net>,
        Miaoqian Lin <linmq006@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Tero Kristo <kristo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Tony Lindgren <tony@...mide.com>, linux-clk@...r.kernel.org,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH] clk: ti: dra7-atl: don't allocate `parent_names' variable

Hi Dario,

I love your patch! Yet something to improve:

[auto build test ERROR on clk/clk-next]
[also build test ERROR on linus/master v6.1-rc1 next-20221017]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dario-Binacchi/clk-ti-dra7-atl-don-t-allocate-parent_names-variable/20221018-005059
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
patch link:    https://lore.kernel.org/r/20221017165028.4194254-1-dario.binacchi%40amarulasolutions.com
patch subject: [PATCH] clk: ti: dra7-atl: don't allocate `parent_names' variable
config: arm-defconfig
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/9eca9eab009687ea2b8cc0d262de7786b6d449b9
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Dario-Binacchi/clk-ti-dra7-atl-don-t-allocate-parent_names-variable/20221018-005059
        git checkout 9eca9eab009687ea2b8cc0d262de7786b6d449b9
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/clk/ti/clk-dra7-atl.c: In function 'of_dra7_atl_clock_setup':
>> drivers/clk/ti/clk-dra7-atl.c:190:27: error: assignment to 'const char * const*' from incompatible pointer type 'const char *' [-Werror=incompatible-pointer-types]
     190 |         init.parent_names = of_clk_get_parent_name(node, 0);
         |                           ^
   cc1: some warnings being treated as errors


vim +190 drivers/clk/ti/clk-dra7-atl.c

   162	
   163	static void __init of_dra7_atl_clock_setup(struct device_node *node)
   164	{
   165		struct dra7_atl_desc *clk_hw = NULL;
   166		struct clk_init_data init = { NULL };
   167		const char *name;
   168		struct clk *clk;
   169	
   170		clk_hw = kzalloc(sizeof(*clk_hw), GFP_KERNEL);
   171		if (!clk_hw) {
   172			pr_err("%s: could not allocate dra7_atl_desc\n", __func__);
   173			return;
   174		}
   175	
   176		clk_hw->hw.init = &init;
   177		clk_hw->divider = 1;
   178		name = ti_dt_clk_name(node);
   179		init.name = name;
   180		init.ops = &atl_clk_ops;
   181		init.flags = CLK_IGNORE_UNUSED;
   182		init.num_parents = of_clk_get_parent_count(node);
   183	
   184		if (init.num_parents != 1) {
   185			pr_err("%s: atl clock %pOFn must have 1 parent\n", __func__,
   186			       node);
   187			goto cleanup;
   188		}
   189	
 > 190		init.parent_names = of_clk_get_parent_name(node, 0);
   191	
   192		clk = ti_clk_register(NULL, &clk_hw->hw, name);
   193		if (!IS_ERR(clk)) {
   194			of_clk_add_provider(node, of_clk_src_simple_get, clk);
   195			return;
   196		}
   197	
   198	cleanup:
   199		kfree(clk_hw);
   200	}
   201	CLK_OF_DECLARE(dra7_atl_clock, "ti,dra7-atl-clock", of_dra7_atl_clock_setup);
   202	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (260502 bytes)