linux-kernel - Re: [PATCH v4 3/4] arch/*/io.h: remove ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Mar 2023 09:45:28 +0800
From:   Baoquan He <bhe@...hat.com>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        linux-mm@...ck.org, arnd@...db.de, mpe@...erman.id.au,
        geert@...ux-m68k.org, mcgrof@...nel.org, hch@...radead.org,
        linux-alpha@...r.kernel.org, linux-hexagon@...r.kernel.org,
        linux-m68k@...ts.linux-m68k.org, linux-mips@...r.kernel.org,
        linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-sh@...r.kernel.org, sparclinux@...r.kernel.org
Subject: Re: [PATCH v4 3/4] arch/*/io.h: remove ioremap_uc in some
 architectures

On 03/09/23 at 03:36pm, Thomas Bogendoerfer wrote:
> On Wed, Mar 08, 2023 at 09:07:09PM +0800, Baoquan He wrote:
> > ioremap_uc() is only meaningful on old x86-32 systems with the PAT
> > extension, and on ia64 with its slightly unconventional ioremap()
> > behavior. So remove the ioremap_uc() definition in architecutures
> > other than x86 and ia64. These architectures all have asm-generic/io.h
> > included and will have the default ioremap_uc() definition which
> > returns NULL.
> > 
> > This changes the existing behaviour, while no need to worry about
> > any breakage because in the only callsite of ioremap_uc(), code
> > has been adjusted to eliminate the impact. Please see
> > atyfb_setup_generic() of drivers/video/fbdev/aty/atyfb_base.c.
> > 
> > If any new invocation of ioremap_uc() need be added, please consider
> > using ioremap() intead or adding a ARCH specific version if necessary.
> > 
> > Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> > Signed-off-by: Baoquan He <bhe@...hat.com>
> > Cc: linux-alpha@...r.kernel.org
> > Cc: linux-hexagon@...r.kernel.org
> > Cc: linux-m68k@...ts.linux-m68k.org
> > Cc: linux-mips@...r.kernel.org
> > Cc: linux-parisc@...r.kernel.org
> > Cc: linuxppc-dev@...ts.ozlabs.org
> > Cc: linux-sh@...r.kernel.org
> > Cc: sparclinux@...r.kernel.org
> > ---
> >  Documentation/driver-api/device-io.rst | 9 +++++----
> >  arch/alpha/include/asm/io.h            | 1 -
> >  arch/hexagon/include/asm/io.h          | 3 ---
> >  arch/m68k/include/asm/kmap.h           | 1 -
> >  arch/mips/include/asm/io.h             | 1 -
> >  arch/parisc/include/asm/io.h           | 2 --
> >  arch/powerpc/include/asm/io.h          | 1 -
> >  arch/sh/include/asm/io.h               | 2 --
> >  arch/sparc/include/asm/io_64.h         | 1 -
> >  9 files changed, 5 insertions(+), 16 deletions(-)
> 
> this doesn't apply to v6.3-rc1... what tree is this based on ?

Sorry, I forgot mentioning this in cover letter. This series is
followup of below patchset, so it's on top of below patchset and based
on v6.3-rc1.

https://lore.kernel.org/all/20230301034247.136007-1-bhe@redhat.com/T/#u
[PATCH v5 00/17] mm: ioremap:  Convert architectures to take GENERIC_IOREMAP way

Thanks
Baoquan