linux-kernel - Re: [PATCH] ksmbd: remove unused is_char

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 25 Mar 2023 10:20:22 +0900
From:   Sergey Senozhatsky <senozhatsky@...omium.org>
To:     Tom Rix <trix@...hat.com>
Cc:     linkinjeon@...nel.org, sfrench@...ba.org, senozhatsky@...omium.org,
        tom@...pey.com, nathan@...nel.org, ndesaulniers@...gle.com,
        linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] ksmbd: remove unused is_char_allowed function

On (23/03/24 13:30), Tom Rix wrote:
> 
> clang with W=1 reports
> fs/ksmbd/unicode.c:122:19: error: unused function
>   'is_char_allowed' [-Werror,-Wunused-function]
> static inline int is_char_allowed(char *ch)
>                   ^
> This function is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Reviewed-by: Sergey Senozhatsky <senozhatsky@...omium.org>

We have a copy of that function in fs/ksmbd/misc.c.