linux-kernel - Re: [RFC PATCH v3 2/4] tools/nolibc: x86-64: Use `rep stosb` for `memset()`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 3 Sep 2023 15:39:33 +0700
From:   Ammar Faizi <ammarfaizi2@...weeb.org>
To:     Willy Tarreau <w@....eu>
Cc:     Alviro Iskandar Setiawan <alviro.iskandar@...weeb.org>,
        Thomas Weißschuh <linux@...ssschuh.net>,
        David Laight <David.Laight@...lab.com>,
        Nicholas Rosenberg <inori@...x.org>,
        Michael William Jonathan <moe@...weeb.org>,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v3 2/4] tools/nolibc: x86-64: Use `rep stosb` for
 `memset()`

[ Resend, I sent it using the wrong From address. ]

On 2023/09/03 午後3:17, Willy Tarreau wrote:
> On Sun, Sep 03, 2023 at 02:34:22AM +0700, Ammar Faizi wrote:
>> On Sun, Sep 03, 2023 at 02:28:18AM +0700, Alviro Iskandar Setiawan wrote:
>>> nit: Be consistent. Use \n\t for the memset too.
>>
>> Good catch, I'll fix that in v4 revision.
> 
> Ammar, I'm overall fine with your series. I can as well add the missing \t
> to your patch while merging it, or wait for your v4, just let me know.

I'm now traveling and will be available in Jakarta on Monday. Thus, I
actually planned to send the v4 revision on Monday.

However, since you don't have further objections to this series, I'll
leave the trivial missing bit to you. Please merge this series and I
will not send a v4 revision.

Thanks,
-- 
Ammar Faizi