linux-kernel - [PATCH 1/1] audit: remove redundant 'fsnotify_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed,  6 Sep 2023 19:51:52 -0600
From:   Wu Bo <bo.wu@...o.com>
To:     linux-kernel@...r.kernel.org
Cc:     Paul Moore <paul@...l-moore.com>, Eric Paris <eparis@...hat.com>,
        audit@...r.kernel.org, Wu Bo <wubo.oduw@...il.com>,
        Wu Bo <bo.wu@...o.com>
Subject: [PATCH 1/1] audit: remove redundant 'fsnotify_put_mark'

'fsnotify_add_inode_mark' has done 'fsnotify_put_mark' if error occurred.
So here to call 'fsnotify_put_mark' is redundant.

Signed-off-by: Wu Bo <bo.wu@...o.com>
---
 kernel/audit_fsnotify.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/audit_fsnotify.c b/kernel/audit_fsnotify.c
index c565fbf66ac8..ff1cdda27653 100644
--- a/kernel/audit_fsnotify.c
+++ b/kernel/audit_fsnotify.c
@@ -103,7 +103,6 @@ struct audit_fsnotify_mark *audit_alloc_mark(struct audit_krule *krule, char *pa
 	ret = fsnotify_add_inode_mark(&audit_mark->mark, inode, 0);
 	if (ret < 0) {
 		audit_mark->path = NULL;
-		fsnotify_put_mark(&audit_mark->mark);
 		audit_mark = ERR_PTR(ret);
 	}
 out:
-- 
2.35.3