linux-kernel - Re: [PATCH 2/3] pinctrl: qcom: Add SM4450 pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Sep 2023 09:23:30 +0800
From:   Tengfei Fan <quic_tengfan@...cinc.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>, <agross@...nel.org>,
        <andersson@...nel.org>, <linus.walleij@...aro.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <conor+dt@...nel.org>, <catalin.marinas@....com>, <will@...nel.org>
CC:     <arnd@...db.de>, <geert+renesas@...der.be>,
        <nfraprado@...labora.com>, <rafal@...ecki.pl>, <peng.fan@....com>,
        <linux-arm-msm@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <quic_tsoni@...cinc.com>,
        <quic_shashim@...cinc.com>, <quic_kaushalk@...cinc.com>,
        <quic_tdas@...cinc.com>, <quic_tingweiz@...cinc.com>,
        <quic_aiquny@...cinc.com>, <kernel@...cinc.com>
Subject: Re: [PATCH 2/3] pinctrl: qcom: Add SM4450 pinctrl driver



在 9/8/2023 4:45 PM, Konrad Dybcio 写道:
> On 8.09.2023 08:38, Tengfei Fan wrote:
>> Add pinctrl driver for TLMM block found in SM4450 SoC.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
>> ---
> [...]
> 
>> +/* Every pin is maintained as a single group, and missing or non-existing pin
> /*
>   * Every pin
> 
>> + * would be maintained as dummy group to synchronize pin group index with
>> + * pin descriptor registered with pinctrl core.
>> + * Clients would not be able to request these dummy pin groups.
>> + */
> [...]
> 
>> +static const int sm4450_acpi_reserved_gpios[] = {
>> +	0, 1, 2, 3, 136, -1
>> +};
> Are you ever going to boot with ACPI on this platform?
> 
> Why reserve UFS_RESET?
> 
> Why are 0-3 reserved? FP reader? Please leave a comment. Or
> delete this.
> 
> Konrad
Thanks Konrad reviewed this patch, will do more test and disscuss about 
this reserve gpio setting, and will remove this in next patch if possible.

-- 
Thx and BRs,
Tengfei Fan