linux-kernel - Re: [PATCH v8 3/8] perf vendor events: Supplement the omitted EventCode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Sep 2023 10:02:37 +0800
From:   Jing Zhang <renyu.zj@...ux.alibaba.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Ian Rogers <irogers@...gle.com>,
        John Garry <john.g.garry@...cle.com>,
        Will Deacon <will@...nel.org>,
        James Clark <james.clark@....com>,
        Mark Rutland <mark.rutland@....com>,
        Mike Leach <mike.leach@...aro.org>,
        Leo Yan <leo.yan@...aro.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-perf-users@...r.kernel.org, linux-doc@...r.kernel.org,
        Zhuo Song <zhuo.song@...ux.alibaba.com>,
        Shuai Xue <xueshuai@...ux.alibaba.com>
Subject: Re: [PATCH v8 3/8] perf vendor events: Supplement the omitted
 EventCode



在 2023/9/13 上午4:34, Arnaldo Carvalho de Melo 写道:
> Em Mon, Sep 11, 2023 at 10:41:16AM +0800, Jing Zhang escreveu:
>>
>> 在 2023/9/9 上午5:18, Ian Rogers 写道:
>>> On Thu, Sep 7, 2023 at 4:58 AM Jing Zhang <renyu.zj@...ux.alibaba.com> wrote:
>>>> If there is an "event=0" in the event description, the EventCode can
>>>> be omitted in the JSON file, and jevent.py will automatically fill in
>>>> "event=0" during parsing.
>>>>
>>>> However, for some events where EventCode and ConfigCode are missing,
>>>> it is not necessary to automatically fill in "event=0", such as the
>>>> CMN event description which is typically "type=xxx, eventid=xxx".
>>>>
>>>> Therefore, before modifying jevent.py to prevent it from automatically
>>>> adding "event=0" by default, it is necessary to fill in all omitted
>>>> EventCodes first.
>>>>
>>>> Signed-off-by: Jing Zhang <renyu.zj@...ux.alibaba.com>
>>> I thought you were going to change the behavior in jevents.py so this
>>> change would be unnecessary. The next time the json is generated by
>>> the script:
>>> https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py
>>> then this will break. It seems easier to workaround the issue in jevents.py.
>>>
>> Okay, I will workaround the issue in jevents.py. Thank you!
> So this means you will resubmit the whole 8-patches long series or
> should we merge this one and then get a followup patch?
> 

Please wait for v9 as there are still some unresolved issues in this series.

Thanks,
Jing

> - Arnaldo
>  
>>> Thanks,
>>> Ian