linux-kernel - Re: [PATCH 1/1] fs: debugfs: fix build error at powerpc platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 30 Sep 2023 09:11:04 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Frank Li <Frank.Li@....com>
Cc:     vkoul@...nel.org, bhe@...hat.com, dmaengine@...r.kernel.org,
        imx@...ts.linux.dev, linux-kernel@...r.kernel.org, lkp@...el.com,
        oe-kbuild-all@...ts.linux.dev, rafael@...nel.org
Subject: Re: [PATCH 1/1] fs: debugfs: fix build error at powerpc platform

On Fri, Sep 29, 2023 at 12:49:20PM -0400, Frank Li wrote:
>    ld: fs/debugfs/file.o: in function `debugfs_print_regs':
>    file.c:(.text+0x95a): undefined reference to `ioread64be'
> >> ld: file.c:(.text+0x9dd): undefined reference to `ioread64'
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202309291322.3pZiyosI-lkp@intel.com/
> Signed-off-by: Frank Li <Frank.Li@....com>

What commit id does this fix?

> ---
>  fs/debugfs/file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
> index 5b8d4fd7c747..b406283806d9 100644
> --- a/fs/debugfs/file.c
> +++ b/fs/debugfs/file.c
> @@ -1179,7 +1179,7 @@ void debugfs_print_regs(struct seq_file *s, const struct debugfs_reg *regs,
>  			seq_printf(s, "%s = 0x%04x\n", regs->name,
>  				  b ? ioread16be(reg) : ioread16(reg));
>  			break;
> -#ifdef CONFIG_64BIT
> +#if defined(ioread64) && defined (ioread64be)

Are you sure this is equivalent?  What if these are functions?

thanks,

greg k-h