linux-kernel - drivers/nvme/common/keyring.c:117:3: sparse: sparse: symbol 'nvme_tls_psk_prio' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 8 Nov 2023 09:10:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hannes Reinecke <hare@...e.de>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Keith Busch <kbusch@...nel.org>,
        Sagi Grimberg <sagi@...mberg.me>
Subject: drivers/nvme/common/keyring.c:117:3: sparse: sparse: symbol
 'nvme_tls_psk_prio' was not declared. Should it be static?

Hi Hannes,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   13d88ac54ddd1011b6e94443958e798aa06eb835
commit: be8e82caa685997b524dc7e4932853fd2fbe6199 nvme-tcp: enable TLS handshake upcall
date:   4 weeks ago
config: i386-randconfig-061-20231108 (https://download.01.org/0day-ci/archive/20231108/202311080803.T1Rc5Q3B-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231108/202311080803.T1Rc5Q3B-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311080803.T1Rc5Q3B-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/nvme/common/keyring.c:117:3: sparse: sparse: symbol 'nvme_tls_psk_prio' was not declared. Should it be static?

vim +/nvme_tls_psk_prio +117 drivers/nvme/common/keyring.c

3bac969b16b7bc Hannes Reinecke 2023-08-24  106  
501cc6f4aca8dc Hannes Reinecke 2023-08-24  107  /*
501cc6f4aca8dc Hannes Reinecke 2023-08-24  108   * NVMe PSK priority list
501cc6f4aca8dc Hannes Reinecke 2023-08-24  109   *
501cc6f4aca8dc Hannes Reinecke 2023-08-24  110   * 'Retained' PSKs (ie 'generated == false')
501cc6f4aca8dc Hannes Reinecke 2023-08-24  111   * should be preferred to 'generated' PSKs,
501cc6f4aca8dc Hannes Reinecke 2023-08-24  112   * and SHA-384 should be preferred to SHA-256.
501cc6f4aca8dc Hannes Reinecke 2023-08-24  113   */
501cc6f4aca8dc Hannes Reinecke 2023-08-24  114  struct nvme_tls_psk_priority_list {
501cc6f4aca8dc Hannes Reinecke 2023-08-24  115  	bool generated;
501cc6f4aca8dc Hannes Reinecke 2023-08-24  116  	enum nvme_tcp_tls_cipher cipher;
501cc6f4aca8dc Hannes Reinecke 2023-08-24 @117  } nvme_tls_psk_prio[] = {
501cc6f4aca8dc Hannes Reinecke 2023-08-24  118  	{ .generated = false,
501cc6f4aca8dc Hannes Reinecke 2023-08-24  119  	  .cipher = NVME_TCP_TLS_CIPHER_SHA384, },
501cc6f4aca8dc Hannes Reinecke 2023-08-24  120  	{ .generated = false,
501cc6f4aca8dc Hannes Reinecke 2023-08-24  121  	  .cipher = NVME_TCP_TLS_CIPHER_SHA256, },
501cc6f4aca8dc Hannes Reinecke 2023-08-24  122  	{ .generated = true,
501cc6f4aca8dc Hannes Reinecke 2023-08-24  123  	  .cipher = NVME_TCP_TLS_CIPHER_SHA384, },
501cc6f4aca8dc Hannes Reinecke 2023-08-24  124  	{ .generated = true,
501cc6f4aca8dc Hannes Reinecke 2023-08-24  125  	  .cipher = NVME_TCP_TLS_CIPHER_SHA256, },
501cc6f4aca8dc Hannes Reinecke 2023-08-24  126  };
501cc6f4aca8dc Hannes Reinecke 2023-08-24  127  

:::::: The code at line 117 was first introduced by commit
:::::: 501cc6f4aca8dc0958c4d9716f0233ba7cff4830 nvme-keyring: implement nvme_tls_psk_default()

:::::: TO: Hannes Reinecke <hare@...e.de>
:::::: CC: Keith Busch <kbusch@...nel.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki