linux-kernel - Re: [PATCH] media: dt-bindings: media: rkisp1: Fix the port description for the parallel interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Nov 2023 02:51:40 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Mehdi Djait <mehdi.djait@...tlin.com>
Cc:     krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
        conor+dt@...nel.org, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        thomas.petazzoni@...tlin.com, alexandre.belloni@...tlin.com,
        paul.kocialkowski@...tlin.com, dafna@...tmail.com,
        helen.koike@...labora.com, heiko@...ech.de,
        paul.elder@...asonboard.com
Subject: Re: [PATCH] media: dt-bindings: media: rkisp1: Fix the port
 description for the parallel interface

Hi Mehdi,

Thank you for the patch.

On Wed, Nov 15, 2023 at 05:44:07PM +0100, Mehdi Djait wrote:
> The bus-type belongs to the endpoint's properties and should therefore
> be moved.
> 
> Fixes: 6a0eaa25bf36 ("media: dt-bindings: media: rkisp1: Add port for parallel interface")
> Signed-off-by: Mehdi Djait <mehdi.djait@...tlin.com>

Good catch.

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  .../devicetree/bindings/media/rockchip-isp1.yaml      | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
> index e466dff8286d..afcaa427d48b 100644
> --- a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
> @@ -90,15 +90,16 @@ properties:
>          description: connection point for input on the parallel interface
>  
>          properties:
> -          bus-type:
> -            enum: [5, 6]
> -
>            endpoint:
>              $ref: video-interfaces.yaml#
>              unevaluatedProperties: false
>  
> -        required:
> -          - bus-type
> +            properties:
> +              bus-type:
> +                enum: [5, 6]
> +
> +            required:
> +              - bus-type
>  
>      anyOf:
>        - required:

-- 
Regards,

Laurent Pinchart