linux-kernel - Re: [PATCH wireless v2 1/4] wifi: b43: Stop/wake correct queue in DMA Tx path when QoS is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 1 Jan 2024 19:01:10 +1100
From: Julian Calaby <julian.calaby@...il.com>
To: Rahul Rameshbabu <sergeantsagara@...tonmail.com>
Cc: Kalle Valo <kvalo@...nel.org>, Larry Finger <Larry.Finger@...inger.net>, 
	Michael Büsch <m@...s.ch>, linux-wireless@...r.kernel.org, 
	b43-dev@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH wireless v2 1/4] wifi: b43: Stop/wake correct queue in DMA
 Tx path when QoS is disabled

Hi Rahul,

On Sun, Dec 31, 2023 at 4:03 PM Rahul Rameshbabu
<sergeantsagara@...tonmail.com> wrote:
>
> When QoS is disabled, the queue priority value will not map to the correct
> ieee80211 queue since there is only one queue. Stop/wake queue 0 when QoS
> is disabled to prevent trying to stop/wake a non-existent queue and failing
> to stop/wake the actual queue instantiated.
>
> [snip]
>
> Fixes: e6f5b934fba8 ("b43: Add QOS support")
> Signed-off-by: Rahul Rameshbabu <sergeantsagara@...tonmail.com>

LGTM

Reviewed-by: Julian Calaby <julian.calaby@...il.com>

Thanks,

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/