linux-kernel - Re: [PATCH wireless v2 4/4] wifi: b43: Disable QoS for bcm4331

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 1 Jan 2024 19:05:01 +1100
From: Julian Calaby <julian.calaby@...il.com>
To: Rahul Rameshbabu <sergeantsagara@...tonmail.com>
Cc: Kalle Valo <kvalo@...nel.org>, Larry Finger <Larry.Finger@...inger.net>, 
	Michael Büsch <m@...s.ch>, linux-wireless@...r.kernel.org, 
	b43-dev@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH wireless v2 4/4] wifi: b43: Disable QoS for bcm4331

Hi Rahul,

On Sun, Dec 31, 2023 at 4:04 PM Rahul Rameshbabu
<sergeantsagara@...tonmail.com> wrote:
>
> bcm4331 seems to not function correctly with QoS support. This may be due
> to issues with currently available firmware or potentially a device
> specific issue.
>
> When queues that are not of the default "best effort" priority are
> selected, traffic appears to not transmit out of the hardware while no
> errors are returned. This behavior is present among all the other priority
> queues: video, voice, and background. While this can be worked around by
> setting a kernel parameter, the default behavior is problematic for most
> users and may be difficult to debug. This patch offers a working out-of-box
> experience for bcm4331 users.
>
> [snip]
>
> Fixes: e6f5b934fba8 ("b43: Add QOS support")
> Signed-off-by: Rahul Rameshbabu <sergeantsagara@...tonmail.com>

LGTM

Reviewed-by: Julian Calaby <julian.calaby@...il.com>

Thanks,

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/