linux-kernel - Re: [PATCH RESEND] arm64: dts: allwinner: a64: Add thermal trip points for GPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 03 Jan 2024 09:40:43 +0800
From: Icenowy Zheng <uwu@...nowy.me>
To: Alexey Klimov <alexey.klimov@...aro.org>, anarsoul@...il.com, 
	tiny.windzz@...il.com, linux-sunxi@...ts.linux.dev
Cc: rafael@...nel.org, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	wens@...e.org, jernej.skrabec@...il.com, samuel@...lland.org, 
	daniel.lezcano@...aro.org, peter.griffin@...aro.org, klimov.linux@...il.com
Subject: Re: [PATCH RESEND] arm64: dts: allwinner: a64: Add thermal trip
 points for GPU

在 2024-01-01星期一的 00:00 +0000，Alexey Klimov写道：
> Without trip points for GPU, the following errors are printed in the
> dmesg log and the sun8i-thermal driver fails to load:
> 
> thermal_sys: Failed to find 'trips' node
> thermal_sys: Failed to find trip points for thermal-sensor id=1
> sun8i-thermal: probe of 1c25000.thermal-sensor failed with error -22
> 
> When thermal zones are defined, trip points definitions are
> mandatory.

I suggest everyone seeing this patch have a look on my patch at [1],
which makes trip points not so mandatory -- it's at least once an
allowed behavior, but lost when converting DT binding to YAML.

[1]
https://lists.infradead.org/pipermail/linux-arm-kernel/2023-July/852088.html

> Trip values for the GPU are assumed to be the same values as the CPU
> ones. The available specs do not provide any hints about thermal
> regimes
> for the GPU and it seems GPU is implemented on the same die as the
> CPU.
> 
> Tested on Pine a64+.
> 
> Cc: Samuel Holland <samuel@...lland.org>
> Cc: Jernej Skrabec <jernej.skrabec@...il.com>
> Cc: Chen-Yu Tsai <wens@...e.org>
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Cc: devicetree@...r.kernel.org
> Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 46
> +++++++++++++++++++
>  1 file changed, 46 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index 62f45f71ec65..07963eea1bf0 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -243,6 +243,29 @@ gpu0_thermal: gpu0-thermal {
>                         polling-delay-passive = <0>;
>                         polling-delay = <0>;
>                         thermal-sensors = <&ths 1>;
> +
> +                       trips {
> +                               gpu0_alert0: gpu0_alert0 {
> +                                       /* milliCelsius */
> +                                       temperature = <75000>;
> +                                       hysteresis = <2000>;
> +                                       type = "passive";
> +                               };
> +
> +                               gpu0_alert1: gpu0_alert1 {
> +                                       /* milliCelsius */
> +                                       temperature = <90000>;
> +                                       hysteresis = <2000>;
> +                                       type = "hot";
> +                               };
> +
> +                               gpu0_crit: gpu0_crit {
> +                                       /* milliCelsius */
> +                                       temperature = <110000>;
> +                                       hysteresis = <2000>;
> +                                       type = "critical";
> +                               };
> +                       };
>                 };
>  
>                 gpu1_thermal: gpu1-thermal {
> @@ -250,6 +273,29 @@ gpu1_thermal: gpu1-thermal {
>                         polling-delay-passive = <0>;
>                         polling-delay = <0>;
>                         thermal-sensors = <&ths 2>;
> +
> +                       trips {
> +                               gpu1_alert0: gpu1_alert0 {
> +                                       /* milliCelsius */
> +                                       temperature = <75000>;
> +                                       hysteresis = <2000>;
> +                                       type = "passive";
> +                               };
> +
> +                               gpu1_alert1: gpu1_alert1 {
> +                                       /* milliCelsius */
> +                                       temperature = <90000>;
> +                                       hysteresis = <2000>;
> +                                       type = "hot";
> +                               };
> +
> +                               gpu1_crit: gpu1_crit {
> +                                       /* milliCelsius */
> +                                       temperature = <110000>;
> +                                       hysteresis = <2000>;
> +                                       type = "critical";
> +                               };
> +                       };
>                 };
>         };
>