linux-kernel - Re: [PATCH v6 08/12] mm/mempolicy: add userland mempolicy arg structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 3 Jan 2024 21:03:51 -0500
From: Gregory Price <gregory.price@...verge.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: Gregory Price <gourry.memverge@...il.com>, linux-mm@...ck.org,
	linux-doc@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
	linux-arch@...r.kernel.org, akpm@...ux-foundation.org,
	arnd@...db.de, tglx@...utronix.de, luto@...nel.org,
	mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
	hpa@...or.com, mhocko@...nel.org, tj@...nel.org,
	ying.huang@...el.com, corbet@....net, rakie.kim@...com,
	hyeongtak.ji@...com, honggyu.kim@...com, vtavarespetr@...ron.com,
	peterz@...radead.org, jgroves@...ron.com, ravis.opensrc@...ron.com,
	sthanneeru@...ron.com, emirakhur@...ron.com, Hasan.Maruf@....com,
	seungjun.ha@...sung.com, Frank van der Linden <fvdl@...gle.com>
Subject: Re: [PATCH v6 08/12] mm/mempolicy: add userland mempolicy arg
 structure

On Wed, Jan 03, 2024 at 04:19:03PM -0800, Randy Dunlap wrote:
> Hi,
> 
> On 1/3/24 14:42, Gregory Price wrote:
> > This patch adds the new user-api argument structure intended for
> > set_mempolicy2 and mbind2.
> > 
> > struct mpol_param {
> >   __u16 mode;
> >   __u16 mode_flags;
> >   __s32 home_node;          /* mbind2: policy home node */
> >   __u16 pol_maxnodes;
> >   __u8 resv[6];
> >   __aligned_u64 *pol_nodes;
> > };
> > 
> >  
> > +Extended Mempolicy Arguments::
> > +
> > +	struct mpol_param {
> > +		__u16 mode;
> > +		__u16 mode_flags;
> > +		__s32 home_node;	 /* mbind2: set home node */
> > +		__u64 pol_maxnodes;
> > +		__aligned_u64 pol_nodes; /* nodemask pointer */
> > +	};
> >
> 
> Can you make the above documentation struct agree with the
> struct in the header below, please?
> (just a difference in the size of pol_maxnodes and the
> 'resv' bytes)
> 
> 

*facepalm* made a note to double check this, and then still didn't.

Thank you for reviewing.  Will fix in the next pass of feedback.

~Gregory