linux-kernel - Re: [PATCH v8 06/26] x86/fpu/xstate: Create guest fpstate with guest specific config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 4 Jan 2024 10:16:49 +0800
From: "Yang, Weijiang" <weijiang.yang@...el.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
CC: "Hansen, Dave" <dave.hansen@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "seanjc@...gle.com" <seanjc@...gle.com>,
	"pbonzini@...hat.com" <pbonzini@...hat.com>, "john.allen@....com"
	<john.allen@....com>, "peterz@...radead.org" <peterz@...radead.org>, "Gao,
 Chao" <chao.gao@...el.com>, "mlevitsk@...hat.com" <mlevitsk@...hat.com>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>
Subject: Re: [PATCH v8 06/26] x86/fpu/xstate: Create guest fpstate with guest
 specific config

On 1/4/2024 2:16 AM, Edgecombe, Rick P wrote:
> On Thu, 2023-12-21 at 09:02 -0500, Yang Weijiang wrote:
>>   #if IS_ENABLED(CONFIG_KVM)
>> -static void __fpstate_reset(struct fpstate *fpstate, u64 xfd);
>> -
>>   static void fpu_init_guest_permissions(struct fpu_guest *gfpu)
>>   {
>>          struct fpu_state_perm *fpuperm;
>> @@ -272,25 +270,54 @@ static void fpu_init_guest_permissions(struct
>> fpu_guest *gfpu)
>>          gfpu->perm = perm & ~FPU_GUEST_PERM_LOCKED;
>>   }
>>   
>> -bool fpu_alloc_guest_fpstate(struct fpu_guest *gfpu)
>> +static struct fpstate *__fpu_alloc_init_guest_fpstate(struct
>> fpu_guest *gfpu)
>>   {
>> +       bool compacted = cpu_feature_enabled(X86_FEATURE_XCOMPACTED);
> With CONFIG_WERROR I get:
> arch/x86/kernel/fpu/core.c: In function
> ‘__fpu_alloc_init_guest_fpstate’:
> arch/x86/kernel/fpu/core.c:275:14: error: unused variable ‘compacted’
> [-Werror=unused-variable]
> 275 |         bool compacted =
> cpu_feature_enabled(X86_FEATURE_XCOMPACTED);

Nice catch! Will remove this unused variable, thanks!

>