| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 Jan 2024 14:44:46 +0800
From: kernel test robot <lkp@...el.com>
To: Guo Ren <guoren@...ux.alibaba.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
Palmer Dabbelt <palmer@...osinc.com>,
Greentime Hu <greentime.hu@...ive.com>,
Andy Chiu <andy.chiu@...ive.com>,
Conor Dooley <conor.dooley@...rochip.com>
Subject: arch/riscv/kernel/signal.c:94:16: sparse: sparse: incorrect type in
initializer (different address spaces)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1f874787ed9a2d78ed59cb21d0d90ac0178eceb0
commit: fa8e7cce55da3569259dc270801885c420eb50fe riscv: Enable Vector code to be built
date: 7 months ago
config: riscv-randconfig-r133-20231115 (https://download.01.org/0day-ci/archive/20240105/202401051446.fmygnjmr-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20240105/202401051446.fmygnjmr-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401051446.fmygnjmr-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> arch/riscv/kernel/signal.c:94:16: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void *__x @@ got void [noderef] __user *[assigned] datap @@
arch/riscv/kernel/signal.c:94:16: sparse: expected void *__x
arch/riscv/kernel/signal.c:94:16: sparse: got void [noderef] __user *[assigned] datap
>> arch/riscv/kernel/signal.c:126:15: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void [noderef] __user *datap @@ got void * @@
arch/riscv/kernel/signal.c:126:15: sparse: expected void [noderef] __user *datap
arch/riscv/kernel/signal.c:126:15: sparse: got void *
>> arch/riscv/kernel/signal.c:126:15: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void [noderef] __user *datap @@ got void * @@
arch/riscv/kernel/signal.c:126:15: sparse: expected void [noderef] __user *datap
arch/riscv/kernel/signal.c:126:15: sparse: got void *
>> arch/riscv/kernel/signal.c:126:15: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void [noderef] __user *datap @@ got void * @@
arch/riscv/kernel/signal.c:126:15: sparse: expected void [noderef] __user *datap
arch/riscv/kernel/signal.c:126:15: sparse: got void *
>> arch/riscv/kernel/signal.c:126:15: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void [noderef] __user *datap @@ got void * @@
arch/riscv/kernel/signal.c:126:15: sparse: expected void [noderef] __user *datap
arch/riscv/kernel/signal.c:126:15: sparse: got void *
vim +94 arch/riscv/kernel/signal.c
8ee0b41898fa26 Greentime Hu 2023-06-05 72
8ee0b41898fa26 Greentime Hu 2023-06-05 73 static long save_v_state(struct pt_regs *regs, void __user **sc_vec)
8ee0b41898fa26 Greentime Hu 2023-06-05 74 {
8ee0b41898fa26 Greentime Hu 2023-06-05 75 struct __riscv_ctx_hdr __user *hdr;
8ee0b41898fa26 Greentime Hu 2023-06-05 76 struct __sc_riscv_v_state __user *state;
8ee0b41898fa26 Greentime Hu 2023-06-05 77 void __user *datap;
8ee0b41898fa26 Greentime Hu 2023-06-05 78 long err;
8ee0b41898fa26 Greentime Hu 2023-06-05 79
8ee0b41898fa26 Greentime Hu 2023-06-05 80 hdr = *sc_vec;
8ee0b41898fa26 Greentime Hu 2023-06-05 81 /* Place state to the user's signal context space after the hdr */
8ee0b41898fa26 Greentime Hu 2023-06-05 82 state = (struct __sc_riscv_v_state __user *)(hdr + 1);
8ee0b41898fa26 Greentime Hu 2023-06-05 83 /* Point datap right after the end of __sc_riscv_v_state */
8ee0b41898fa26 Greentime Hu 2023-06-05 84 datap = state + 1;
8ee0b41898fa26 Greentime Hu 2023-06-05 85
8ee0b41898fa26 Greentime Hu 2023-06-05 86 /* datap is designed to be 16 byte aligned for better performance */
8ee0b41898fa26 Greentime Hu 2023-06-05 87 WARN_ON(unlikely(!IS_ALIGNED((unsigned long)datap, 16)));
8ee0b41898fa26 Greentime Hu 2023-06-05 88
8ee0b41898fa26 Greentime Hu 2023-06-05 89 riscv_v_vstate_save(current, regs);
8ee0b41898fa26 Greentime Hu 2023-06-05 90 /* Copy everything of vstate but datap. */
8ee0b41898fa26 Greentime Hu 2023-06-05 91 err = __copy_to_user(&state->v_state, ¤t->thread.vstate,
8ee0b41898fa26 Greentime Hu 2023-06-05 92 offsetof(struct __riscv_v_ext_state, datap));
8ee0b41898fa26 Greentime Hu 2023-06-05 93 /* Copy the pointer datap itself. */
8ee0b41898fa26 Greentime Hu 2023-06-05 @94 err |= __put_user(datap, &state->v_state.datap);
8ee0b41898fa26 Greentime Hu 2023-06-05 95 /* Copy the whole vector content to user space datap. */
8ee0b41898fa26 Greentime Hu 2023-06-05 96 err |= __copy_to_user(datap, current->thread.vstate.datap, riscv_v_vsize);
8ee0b41898fa26 Greentime Hu 2023-06-05 97 /* Copy magic to the user space after saving all vector conetext */
8ee0b41898fa26 Greentime Hu 2023-06-05 98 err |= __put_user(RISCV_V_MAGIC, &hdr->magic);
8ee0b41898fa26 Greentime Hu 2023-06-05 99 err |= __put_user(riscv_v_sc_size, &hdr->size);
8ee0b41898fa26 Greentime Hu 2023-06-05 100 if (unlikely(err))
8ee0b41898fa26 Greentime Hu 2023-06-05 101 return err;
8ee0b41898fa26 Greentime Hu 2023-06-05 102
8ee0b41898fa26 Greentime Hu 2023-06-05 103 /* Only progress the sv_vec if everything has done successfully */
8ee0b41898fa26 Greentime Hu 2023-06-05 104 *sc_vec += riscv_v_sc_size;
8ee0b41898fa26 Greentime Hu 2023-06-05 105 return 0;
8ee0b41898fa26 Greentime Hu 2023-06-05 106 }
8ee0b41898fa26 Greentime Hu 2023-06-05 107
8ee0b41898fa26 Greentime Hu 2023-06-05 108 /*
8ee0b41898fa26 Greentime Hu 2023-06-05 109 * Restore Vector extension context from the user's signal frame. This function
8ee0b41898fa26 Greentime Hu 2023-06-05 110 * assumes a valid extension header. So magic and size checking must be done by
8ee0b41898fa26 Greentime Hu 2023-06-05 111 * the caller.
8ee0b41898fa26 Greentime Hu 2023-06-05 112 */
8ee0b41898fa26 Greentime Hu 2023-06-05 113 static long __restore_v_state(struct pt_regs *regs, void __user *sc_vec)
8ee0b41898fa26 Greentime Hu 2023-06-05 114 {
8ee0b41898fa26 Greentime Hu 2023-06-05 115 long err;
8ee0b41898fa26 Greentime Hu 2023-06-05 116 struct __sc_riscv_v_state __user *state = sc_vec;
8ee0b41898fa26 Greentime Hu 2023-06-05 117 void __user *datap;
8ee0b41898fa26 Greentime Hu 2023-06-05 118
8ee0b41898fa26 Greentime Hu 2023-06-05 119 /* Copy everything of __sc_riscv_v_state except datap. */
8ee0b41898fa26 Greentime Hu 2023-06-05 120 err = __copy_from_user(¤t->thread.vstate, &state->v_state,
8ee0b41898fa26 Greentime Hu 2023-06-05 121 offsetof(struct __riscv_v_ext_state, datap));
8ee0b41898fa26 Greentime Hu 2023-06-05 122 if (unlikely(err))
8ee0b41898fa26 Greentime Hu 2023-06-05 123 return err;
8ee0b41898fa26 Greentime Hu 2023-06-05 124
8ee0b41898fa26 Greentime Hu 2023-06-05 125 /* Copy the pointer datap itself. */
8ee0b41898fa26 Greentime Hu 2023-06-05 @126 err = __get_user(datap, &state->v_state.datap);
8ee0b41898fa26 Greentime Hu 2023-06-05 127 if (unlikely(err))
8ee0b41898fa26 Greentime Hu 2023-06-05 128 return err;
8ee0b41898fa26 Greentime Hu 2023-06-05 129 /*
8ee0b41898fa26 Greentime Hu 2023-06-05 130 * Copy the whole vector content from user space datap. Use
8ee0b41898fa26 Greentime Hu 2023-06-05 131 * copy_from_user to prevent information leak.
8ee0b41898fa26 Greentime Hu 2023-06-05 132 */
8ee0b41898fa26 Greentime Hu 2023-06-05 133 err = copy_from_user(current->thread.vstate.datap, datap, riscv_v_vsize);
8ee0b41898fa26 Greentime Hu 2023-06-05 134 if (unlikely(err))
8ee0b41898fa26 Greentime Hu 2023-06-05 135 return err;
8ee0b41898fa26 Greentime Hu 2023-06-05 136
8ee0b41898fa26 Greentime Hu 2023-06-05 137 riscv_v_vstate_restore(current, regs);
8ee0b41898fa26 Greentime Hu 2023-06-05 138
8ee0b41898fa26 Greentime Hu 2023-06-05 139 return err;
8ee0b41898fa26 Greentime Hu 2023-06-05 140 }
8ee0b41898fa26 Greentime Hu 2023-06-05 141 #else
8ee0b41898fa26 Greentime Hu 2023-06-05 142 #define save_v_state(task, regs) (0)
8ee0b41898fa26 Greentime Hu 2023-06-05 143 #define __restore_v_state(task, regs) (0)
8ee0b41898fa26 Greentime Hu 2023-06-05 144 #endif
8ee0b41898fa26 Greentime Hu 2023-06-05 145
:::::: The code at line 94 was first introduced by commit
:::::: 8ee0b41898fa26f66e32237f179b6989c65600d6 riscv: signal: Add sigcontext save/restore for vector
:::::: TO: Greentime Hu <greentime.hu@...ive.com>
:::::: CC: Palmer Dabbelt <palmer@...osinc.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists