linux-kernel - Re: [PATCH] arm64: dts: qcom: qcm6490: Update PSCI suspend param for cluster sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 5 Jan 2024 11:05:51 +0100
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Maulik Shah <quic_mkshah@...cinc.com>, agross@...nel.org,
 andersson@...nel.org, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 conor+dt@...nel.org, luca.weiss@...rphone.com,
 cros-qcom-dts-watchers@...omium.org
Cc: linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, quic_lsrao@...cinc.com
Subject: Re: [PATCH] arm64: dts: qcom: qcm6490: Update PSCI suspend param for
 cluster sleep

On 5.01.2024 08:02, Maulik Shah wrote:
> QCM6490 uses Trustzone as firmware whereas SC7280 uses arm trusted
> firmware. The PSCI suspend param is different in Trustzone for cluster
> sleep. Update the same for qcm6490 based idp and fairphone fp5 boards.
> 
> Signed-off-by: Maulik Shah <quic_mkshah@...cinc.com>
> ---

Nice spot!

For things that are chrome-specific, I'd prefer them to be moved to
-chrome.dtsi and then the "normal" (LA+LE+WP+friends) values to
stay as default.

>  arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 4 ++++
>  arch/arm64/boot/dts/qcom/qcm6490-idp.dts           | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> index 176898c9dbbd..b56f6f26d96f 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> @@ -446,6 +446,10 @@
>  	};
>  };
>  
> +&CLUSTER_SLEEP_0 {
> +	arm,psci-suspend-param = <0x4100b344>;
>

I think the residency times should also be updated here.

Moreover, I'm seeing additional sleep states here (APSS PC, CX RET
and this one being AOSS SLEEP), with values 0x4<<4, 0x134<<4,
0xb34<<4 (the one you added here) respectively.

Could you please add them as well, similar to [1]?

Konrad

[1] https://lore.kernel.org/linux-arm-msm/20230619-topic-sc8280xp-idle-v2-1-cde50bf02f3c@linaro.org/