linux-kernel - Re: [PATCH] usb: typec: tipd: fix use of device-specific init function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 5 Jan 2024 13:42:47 +0100
From: Javier Carrasco <javier.carrasco.cruz@...il.com>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Roger Quadros <rogerq@...nel.org>,
 Javier Carrasco <javier.carrasco@...fvision.net>, linux-usb@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: typec: tipd: fix use of device-specific init
 function

On 05.01.24 13:36, Heikki Krogerus wrote:
> On Thu, Jan 04, 2024 at 06:07:12PM +0100, Javier Carrasco wrote:
>> The current implementation supports device-pecific callbacks for the
>> init function with a function pointer. The patch that introduced this
>> feature did not update one call to the tps25750 init function to turn it
>> into a call with the new pointer in the resume function.
>>
>> Fixes: d49f90822015 ("usb: typec: tipd: add init and reset functions to tipd_data")
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> 
> This was suggested by Roger, no?
> 

Yes, it was. Thanks for the reminder.

Could the following trailer be added before applying?

Suggested-by: Roger Quadros <rogerq@...nel.org>

Otherwise I will resend the patch with that addition.

> Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> 
>> ---
>>  drivers/usb/typec/tipd/core.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
>> index a956eb976906..8a7cdfee27a1 100644
>> --- a/drivers/usb/typec/tipd/core.c
>> +++ b/drivers/usb/typec/tipd/core.c
>> @@ -1495,7 +1495,7 @@ static int __maybe_unused tps6598x_resume(struct device *dev)
>>  		return ret;
>>  
>>  	if (ret == TPS_MODE_PTCH) {
>> -		ret = tps25750_init(tps);
>> +		ret = tps->data->init(tps);
>>  		if (ret)
>>  			return ret;
>>  	}
> 
> thans,
>