linux-kernel - Re: [PATCH] coresight: make coresight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 5 Jan 2024 14:22:43 +0000
From: Suzuki K Poulose <suzuki.poulose@....com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 coresight@...ts.linaro.org
Cc: linux-kernel@...r.kernel.org, Mike Leach <mike.leach@...aro.org>,
 James Clark <james.clark@....com>, Leo Yan <leo.yan@...aro.org>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] coresight: make coresight_bustype const

On 05/01/2024 12:33, Greg Kroah-Hartman wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the coresight_bustype variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 
> Cc: Suzuki K Poulose <suzuki.poulose@....com>
> Cc: Mike Leach <mike.leach@...aro.org>
> Cc: James Clark <james.clark@....com>
> Cc: Leo Yan <leo.yan@...aro.org>
> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> Cc: coresight@...ts.linaro.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>   drivers/hwtracing/coresight/coresight-core.c | 2 +-
>   include/linux/coresight.h                    | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
> index 9fabe00a40d6..24c49e581737 100644
> --- a/drivers/hwtracing/coresight/coresight-core.c
> +++ b/drivers/hwtracing/coresight/coresight-core.c
> @@ -1796,7 +1796,7 @@ char *coresight_alloc_device_name(struct coresight_dev_list *dict,
>   }
>   EXPORT_SYMBOL_GPL(coresight_alloc_device_name);
>   
> -struct bus_type coresight_bustype = {
> +const struct bus_type coresight_bustype = {
>   	.name	= "coresight",
>   };
>   
> diff --git a/include/linux/coresight.h b/include/linux/coresight.h
> index a269fffaf991..8fe75a0d7693 100644
> --- a/include/linux/coresight.h
> +++ b/include/linux/coresight.h
> @@ -35,7 +35,7 @@
>   
>   #define CORESIGHT_UNLOCK	0xc5acce55
>   
> -extern struct bus_type coresight_bustype;
> +extern const struct bus_type coresight_bustype;

Thanks, for the patch. I will queue this for v6.8.

Thanks
Suzuki
>   
>   enum coresight_dev_type {
>   	CORESIGHT_DEV_TYPE_SINK,