linux-kernel - Re: [PATCH AUTOSEL 6.7 076/108] net: atlantic: eliminate double free in error handling logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 16 Jan 2024 17:38:32 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Sasha Levin <sashal@...nel.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org, Igor Russkikh
 <irusskikh@...vell.com>, epomozov@...vell.com, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, richardcochran@...il.com,
 ast@...nel.org, daniel@...earbox.net, hawk@...nel.org,
 john.fastabend@...il.com, netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.7 076/108] net: atlantic: eliminate double
 free in error handling logic

On Tue, 16 Jan 2024 14:39:42 -0500 Sasha Levin wrote:
> Driver has a logic leak in ring data allocation/free,
> where aq_ring_free could be called multiple times on same ring,
> if system is under stress and got memory allocation error.

This is a bit big, and the commit message is a leftover
from previous version which mixed up the fix with the cleanup.
The fix went in as 7bb26ea74aa86, I'd vote to drop the cleanup
from stable, but it "looks correct" so no strong feelings.