linux-kernel - Re: [PATCH] kconfig: menuconfig: Make hidden options show as dim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 22 Jan 2024 13:13:27 +0900
From: Tomasz Figa <tfiga@...omium.org>
To: Nicolas Schier <n.schier@....de>, Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Jesse Taube <Mr.Bossman075@...il.com>
Subject: Re: [PATCH] kconfig: menuconfig: Make hidden options show as dim

On Tue, Jan 16, 2024 at 9:01 PM Nicolas Schier <n.schier@....de> wrote:
>
> On Tue, Jan 16, 2024 at 07:58:05PM +0900, Masahiro Yamada wrote:
> > On Mon, Jan 15, 2024 at 2:04 PM Tomasz Figa <tfiga@...omium.org> wrote:
> > >
> > > On Sat, Jan 13, 2024 at 8:23 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
> > > >
> > > > On Wed, Jan 10, 2024 at 10:05 PM Tomasz Figa <tfiga@...omium.org> wrote:
> > > > >
> > > > > On Fri, Dec 29, 2023 at 1:10 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
> > > > > >
> > > > > > On Thu, Dec 28, 2023 at 2:46 PM Tomasz Figa <tfiga@...omium.org> wrote:
> > > > > > >
> > > > > > > When hidden options are toggled on (using 'z'), the number of options
> > > > > > > on the screen can be overwhelming and may make it hard to distinguish
> > > > > > > between available and hidden ones. Make them easier to distinguish by
> > > > > > > displaying the hidden one as dim (using the A_DIM curses attribute).
> > > > > > >
> > > > > > > Signed-off-by: Tomasz Figa <tfiga@...omium.org>
> > > > > >
> > > > > >
> > > > > >
> > > > > > Do you think this is useful?
> > > > > >
> > > > > > This changes the color only when you select a hidden item.
> > > > > >
> > > > > >
> > > > > > For unselected items, you cannot distinguish hidden ones,
> > > > > > as A_DIM has no effect to black text.
> > > > > >
> > > > > >
> > > > >
> > > > > Hmm, are you sure about that? For me it seems to dim the text. it
> > > > > seems to be also used in the existing code for dlg.button_inactive.atr
> > > > > of the mono theme:
> > > > >
> > > > > https://elixir.bootlin.com/linux/latest/source/scripts/kconfig/lxdialog/util.c#L26
> > > >
> > > >
> > > >
> > > > Then, your code works only on the mono theme.
> > > > (when your terminal does not support color, or
> > > > "MENUCONFIG_COLOR=mono make menuconfig")
> > > >
> > >
> > > No, that's not what I meant. It works for me for all themes, see the
> > > screenshot at https://postimg.cc/sBsM0twT . The terminal is tmux
> > > inside hterm (which in turn is supposed to be compatible with xterm).
> > > I guess I can test a couple of different terminals.
> > >
> > > In which terminal is it not working for you?
> >
> >
> > I use gnome-terminal.
> > The disto is Ubuntu 23.10
>
> I see the same behaviour as Masahiro described with foot 1.13.1 on
> Debian 12.

Thanks for testing! I'll use the two for my testing as well and try to
figure out something more portable.

Best regards,
Tomasz