linux-kernel - Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: modify the wrong compatible name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 25 Jan 2024 09:27:05 +0800
From: Tengfei Fan <quic_tengfan@...cinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Dmitry Baryshkov
	<dmitry.baryshkov@...aro.org>
CC: <andersson@...nel.org>, <konrad.dybcio@...aro.org>,
        <linus.walleij@...aro.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel@...cinc.com>
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: modify the wrong
 compatible name



On 1/24/2024 4:46 PM, Krzysztof Kozlowski wrote:
> On 24/01/2024 09:07, Dmitry Baryshkov wrote:
>> On Wed, 24 Jan 2024 at 08:38, Krzysztof Kozlowski
>> <krzysztof.kozlowski@...aro.org> wrote:
>>>
>>> On 24/01/2024 03:33, Tengfei Fan wrote:
>>>> Use right compatible name "qcom,sm4450-tlmm" instead of
>>>> "qcom,sm4450-pinctrl".
>>>
>>> Why do you claim this one is right and other is wrong? Provide
>>> arguments. To me the compatible looks correct.
>>
>> Yeah, but the driver (and the dtsi) use -tlmm
> 
> Are they merged? If so, it would be the argument for the commit msg.
> Just provide some rationale why this is done this way, not the other
> (fixing driver and DTS).
> 
> Best regards,
> Krzysztof
> 

This commit message is causing some confusion. I will update this commit 
messge for just provide retionale why is this patch needed.

-- 
Thx and BRs,
Tengfei Fan