linux-kernel - Re: [PATCH v2 2/7] firmware: coreboot: Generate aliases for coreboot modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 30 Jan 2024 16:01:57 -0800
From: Brian Norris <briannorris@...omium.org>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
	Nícolas F. R. A. Prado <nfraprado@...labora.com>, 
	Tzung-Bi Shih <tzungbi@...nel.org>, kernel@...labora.com, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, chrome-platform@...ts.linux.dev, 
	Abhijit Gangurde <abhijit.gangurde@....com>, Masahiro Yamada <masahiroy@...nel.org>, 
	Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>, Nipun Gupta <nipun.gupta@....com>, 
	Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@....com>, Umang Jain <umang.jain@...asonboard.com>, 
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/7] firmware: coreboot: Generate aliases for coreboot modules

On Tue, Jan 30, 2024 at 3:51 PM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> On Tue, Jan 23, 2024 at 02:06:14PM -0800, Brian Norris wrote:
> > "Don't you want to have a driver data or so associated with this?"
..
> But why limit yourself to 32bits now?  Why not make it 64?  It is going
> to be sent to userspace, so you have to be very careful about it.

Is that question related to the question I pasted/replied to, about
driver data? Or a new topic? Sorry if I'm misunderstanding.

Anyway, for the size of the tag field: I don't have a strong opinion.
But FWIW, they're coming from this project:

https://review.coreboot.org/plugins/gitiles/coreboot/+/269b23280f928510bcadd23182294e5b9dad11ec/payloads/libpayload/include/coreboot_tables.h#36

As you can see there, we're extremely far from exhausting 16 bits, let alone 32.

Brian