netdev - Re: [PATCH][IPSEC][6/7] inter address family ipsec tunnel

lists.openwall.net		lists / announce john-users owl-users popa3d-users / xvendor oss-security / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4
Open Source and information security mailing list archives

Order Openwall GNU/*/Linux 2.0 on a CD with delivery worldwide

[<prev] [next>] [thread-next>] [month] [year] [list]

Date:	Thu, 30 Nov 2006 17:05:03 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	kazunori@...azawa.org
Subject: Re: [PATCH][IPSEC][6/7] inter address family ipsec tunnel

From: Kazunori MIYAZAWA <kazunori@...azawa.org>
Date: Fri, 24 Nov 2006 14:39:01 +0900

> This patch fixes mtu calculation of IPv4
> 
> ip_append_data should refer the mtu of "dst" not "path".
> if "dst" is stacked, "path" is the actual dst_entry in
> the routing table.
> therefore the mtu of "path" equals link mtu which is
> depends on the device so that it ignores the header length
> and the trailer length
> "dst" has mtu for creating packet.
> 
> Signed-off-by: Miika Komu <miika@....fi>
> Signed-off-by: Diego Beltrami <Diego.Beltrami@...t.fi>
> Signed-off-by: Kazunori Miyazawa <miyazawa@...ux-ipv6.org>

I'm not sure about this change.

If you look at the code in this function, "mtu" is always used with
adjustments via 'exthdrlen' (which is set to rt->u.dst.header_len).
So it seems the encapsulation is taken into account.

Perhaps any problem you are seeing is some artifact of the ipv6 in
ipv4 tunnel implementation.  Otherwise we'd have other reports of this
problem, wouldn't we?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html