netdev - Re: zd1211 ported to Devicescape stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 2 Dec 2006 09:54:15 -0500
From:	Michael Wu <flamingice@...rmilk.net>
To:	Ulrich Kunitz <kune@...ne-taler.de>
Cc:	Daniel Drake <dsd@...too.org>, netdev@...r.kernel.org,
	John Linville <linville@...driver.com>,
	Luis Rodriguez <mcgrof@...il.com>
Subject: Re: zd1211 ported to Devicescape stack

On Saturday 02 December 2006 08:25, Ulrich Kunitz wrote:
> > 	- The original driver does not seem to check if a frame has been
> > successfully TXed (as in RXed an ACK), so the port does not properly
> > report to the stack whether or not a TX succeeded.
>
> TX is atomic. Do you really want to spin for the received ACK? Layer 2
> doesn't need to make any guarantees for packet transmission, so I have
> trouble to see the point here. The Linux Device Driver book says
> explicitly that packet transmission must not have been completed
> at the point in time the function returns.
>
And it doesn't. Sleeping at that point would be bad. However, the p54 driver 
looks for special frames from the card that report the success/failure of 
sent frames, and adm8211 can tell if a frame was TXed successfully on TX ring 
cleanup. The notification is then done by calling ieee80211_tx_status, not by 
returning an error code. No sleeping necessary. This is needed for the upper 
layer to resend frames and to also do rate control.

> I would suggest to maintain it until d80211 has
> complete regulatory domains support.
>
Why? It's not like any other d80211 drivers have regulatory domains support, 
and they need the exactly the same features that zd1211 needs. Also, the 
limited support for regulatory domains that d80211 does have restricts it to 
channels 1-11 (FCC) regardless, so the code would not be effective.

Thanks,
-Michael Wu

Content of type "application/pgp-signature" skipped