netdev - Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 7 Dec 2006 09:19:57 -0800
From:	Stephen Hemminger <shemminger@...l.org>
To:	Andrew Victor <andrew@...people.com>
Cc:	netdev@...r.kernel.org, jgarzik@...ox.com
Subject: Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 3

On 05 Dec 2006 09:29:52 +0200
Andrew Victor <andrew@...people.com> wrote:

> hi Stephen,
> 
> > Use netdev_alloc_skb instead. It sets skb->dev so you don't have to.
> 
> netdev_alloc_skb() seems to cause 2 function calls [__netdev_alloc_skb()
> and __alloc_skb()], instead of just 1 for the dev_alloc_skb() case.
> It might be more efficient if the driver manually sets skb->dev.

That is trivial, and netdev_alloc_skb() is setup to handle other
issues in future.


-- 
Stephen Hemminger <shemminger@...l.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html