netdev - Re: [PATCH][NET_SCHED] sch_htb: turn intermediate classes into leaves

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 08 Dec 2006 00:27:23 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	jarkao2@...pl, netdev@...r.kernel.org, devik@....cz
Subject: Re: [PATCH][NET_SCHED] sch_htb: turn intermediate classes into
 leaves

From: Patrick McHardy <kaber@...sh.net>
Date: Thu, 30 Nov 2006 14:12:32 +0100

> Jarek Poplawski wrote:
> > On Thu, Nov 30, 2006 at 01:26:34PM +0100, Patrick McHardy wrote:
> > 
> >>Jarek Poplawski wrote:
> >>
> >>>[NET_SCHED] sch_htb:
> >>>
> >>>[PATCH 2.6.19-rc6 with "Fix endless loops" set of patches]
> >>>
> >>>- turn intermediate classes into leaves again when their
> >>>  last child is deleted (struct htb_class changed)
> >>
> >>Looks good to me too, but it still seems to be missing
> >>class level adjustment after deletion. The classification
> >>function refuses to queue packets to classes with level > 0.
> > 
> > 
> > +static void htb_parent_to_leaf(struct htb_class *cl, struct Qdisc *new_q)
> > +{
> > +	struct htb_class *parent = cl->parent;
> > +
> > +	BUG_TRAP(!cl->level && cl->un.leaf.q && !cl->prio_activity);
> > +
> > +	parent->level = 0;
> > 
> > I've thought this is enough, but probably you mean something
> > else? 
> 
> I missed that, thanks.

Patch applied, thanks again.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html